Re: [PATCH v5 4/4] zram: introduce zram memory tracking

2018-04-20 Thread Minchan Kim
gt; > Good point! > > > > > > I just referenced it from ftrace because I thought the goal is similiar > > > "no need to be exact unless the drift is frequent but wanted to be fast" > > > > > > AFAIK, ftrace/printk is active user of the function s

Re: [PATCH v5 4/4] zram: introduce zram memory tracking

2018-04-20 Thread Minchan Kim
eferenced it from ftrace because I thought the goal is similiar > > > "no need to be exact unless the drift is frequent but wanted to be fast" > > > > > > AFAIK, ftrace/printk is active user of the function so if the problem > > > happens frequ

Re: [PATCH v5 4/4] zram: introduce zram memory tracking

2018-04-19 Thread Minchan Kim
On Fri, Apr 20, 2018 at 11:18:34AM +0900, Sergey Senozhatsky wrote: > On (04/20/18 11:09), Minchan Kim wrote: > [..] > > > hm, OK, can we get this info into the changelog? > > > > No problem. I will add as follows, > > > > "I used the feature a few years ago to find memory hoggers in userspace

Re: [PATCH v5 4/4] zram: introduce zram memory tracking

2018-04-19 Thread Minchan Kim
On Fri, Apr 20, 2018 at 11:18:34AM +0900, Sergey Senozhatsky wrote: > On (04/20/18 11:09), Minchan Kim wrote: > [..] > > > hm, OK, can we get this info into the changelog? > > > > No problem. I will add as follows, > > > > "I used the feature a few years ago to find memory hoggers in userspace

Re: [PATCH v5 4/4] zram: introduce zram memory tracking

2018-04-19 Thread Sergey Senozhatsky
On (04/20/18 11:09), Minchan Kim wrote: [..] > > hm, OK, can we get this info into the changelog? > > No problem. I will add as follows, > > "I used the feature a few years ago to find memory hoggers in userspace > to notice them what memory they have wasted without touch for a long time. >

Re: [PATCH v5 4/4] zram: introduce zram memory tracking

2018-04-19 Thread Sergey Senozhatsky
On (04/20/18 11:09), Minchan Kim wrote: [..] > > hm, OK, can we get this info into the changelog? > > No problem. I will add as follows, > > "I used the feature a few years ago to find memory hoggers in userspace > to notice them what memory they have wasted without touch for a long time. >

Re: [PATCH v5 4/4] zram: introduce zram memory tracking

2018-04-19 Thread Minchan Kim
On Wed, Apr 18, 2018 at 02:07:15PM -0700, Andrew Morton wrote: > On Wed, 18 Apr 2018 10:26:36 +0900 Minchan Kim wrote: > > > Hi Andrew, > > > > On Tue, Apr 17, 2018 at 02:59:21PM -0700, Andrew Morton wrote: > > > On Mon, 16 Apr 2018 18:09:46 +0900 Minchan Kim

Re: [PATCH v5 4/4] zram: introduce zram memory tracking

2018-04-19 Thread Minchan Kim
On Wed, Apr 18, 2018 at 02:07:15PM -0700, Andrew Morton wrote: > On Wed, 18 Apr 2018 10:26:36 +0900 Minchan Kim wrote: > > > Hi Andrew, > > > > On Tue, Apr 17, 2018 at 02:59:21PM -0700, Andrew Morton wrote: > > > On Mon, 16 Apr 2018 18:09:46 +0900 Minchan Kim wrote: > > > > > > > zRam as swap

Re: [PATCH v5 4/4] zram: introduce zram memory tracking

2018-04-18 Thread Andrew Morton
On Wed, 18 Apr 2018 10:26:36 +0900 Minchan Kim wrote: > Hi Andrew, > > On Tue, Apr 17, 2018 at 02:59:21PM -0700, Andrew Morton wrote: > > On Mon, 16 Apr 2018 18:09:46 +0900 Minchan Kim wrote: > > > > > zRam as swap is useful for small memory device.

Re: [PATCH v5 4/4] zram: introduce zram memory tracking

2018-04-18 Thread Andrew Morton
On Wed, 18 Apr 2018 10:26:36 +0900 Minchan Kim wrote: > Hi Andrew, > > On Tue, Apr 17, 2018 at 02:59:21PM -0700, Andrew Morton wrote: > > On Mon, 16 Apr 2018 18:09:46 +0900 Minchan Kim wrote: > > > > > zRam as swap is useful for small memory device. However, swap means > > > those pages on

Re: [PATCH v5 4/4] zram: introduce zram memory tracking

2018-04-17 Thread Minchan Kim
Hi Andrew, On Tue, Apr 17, 2018 at 02:59:21PM -0700, Andrew Morton wrote: > On Mon, 16 Apr 2018 18:09:46 +0900 Minchan Kim wrote: > > > zRam as swap is useful for small memory device. However, swap means > > those pages on zram are mostly cold pages due to VM's LRU

Re: [PATCH v5 4/4] zram: introduce zram memory tracking

2018-04-17 Thread Minchan Kim
Hi Andrew, On Tue, Apr 17, 2018 at 02:59:21PM -0700, Andrew Morton wrote: > On Mon, 16 Apr 2018 18:09:46 +0900 Minchan Kim wrote: > > > zRam as swap is useful for small memory device. However, swap means > > those pages on zram are mostly cold pages due to VM's LRU algorithm. > > Especially,

Re: [PATCH v5 4/4] zram: introduce zram memory tracking

2018-04-17 Thread Andrew Morton
On Mon, 16 Apr 2018 18:09:46 +0900 Minchan Kim wrote: > zRam as swap is useful for small memory device. However, swap means > those pages on zram are mostly cold pages due to VM's LRU algorithm. > Especially, once init data for application are touched for launching, > they

Re: [PATCH v5 4/4] zram: introduce zram memory tracking

2018-04-17 Thread Andrew Morton
On Mon, 16 Apr 2018 18:09:46 +0900 Minchan Kim wrote: > zRam as swap is useful for small memory device. However, swap means > those pages on zram are mostly cold pages due to VM's LRU algorithm. > Especially, once init data for application are touched for launching, > they tend to be not

[PATCH v5 4/4] zram: introduce zram memory tracking

2018-04-16 Thread Minchan Kim
zRam as swap is useful for small memory device. However, swap means those pages on zram are mostly cold pages due to VM's LRU algorithm. Especially, once init data for application are touched for launching, they tend to be not accessed any more and finally swapped out. zRAM can store such cold

[PATCH v5 4/4] zram: introduce zram memory tracking

2018-04-16 Thread Minchan Kim
zRam as swap is useful for small memory device. However, swap means those pages on zram are mostly cold pages due to VM's LRU algorithm. Especially, once init data for application are touched for launching, they tend to be not accessed any more and finally swapped out. zRAM can store such cold