Re: [PATCH v5 4/5] ARM: EXYNOS: Add platform driver support for Exynos PMU

2014-07-08 Thread Tomasz Figa
On 05.07.2014 09:09, Pankaj Dubey wrote: > On Monday, June 30, 2014 Tomasz Figa wrote: >> On 25.06.2014 16:03, Pankaj Dubey wrote: >>> + >>> + if (pmu_context->pmu_data && pmu_context->pmu_data->pmu_init) >> >> In what conditions pmu_data will be NULL? >> > > What if we want driver to be probed

RE: [PATCH v5 4/5] ARM: EXYNOS: Add platform driver support for Exynos PMU

2014-07-05 Thread Pankaj Dubey
Hi Tomasz, On Monday, June 30, 2014 Tomasz Figa wrote: > Hi Pankaj, > > Please see my comments inline. > > On 25.06.2014 16:03, Pankaj Dubey wrote: > > This patch modifies Exynos Power Management Unit (PMU) initialization > > implementation in following way: > > > > - Added platform driver supp

Re: [PATCH v5 4/5] ARM: EXYNOS: Add platform driver support for Exynos PMU

2014-06-30 Thread Tomasz Figa
Hi Pankaj, Please see my comments inline. On 25.06.2014 16:03, Pankaj Dubey wrote: > This patch modifies Exynos Power Management Unit (PMU) initialization > implementation in following way: > > - Added platform driver support and probe function where Exynos PMU > driver will register itself as

[PATCH v5 4/5] ARM: EXYNOS: Add platform driver support for Exynos PMU

2014-06-25 Thread Pankaj Dubey
This patch modifies Exynos Power Management Unit (PMU) initialization implementation in following way: - Added platform driver support and probe function where Exynos PMU driver will register itself as syscon provider with syscon framework. - Added platform struct exynos_pmu_data to hold platfor