Re: [PATCH v5 4/6] i2c: at91: add support for new alternative command mode

2015-06-09 Thread Wolfram Sang
Nicolas, > > +static struct at91_twi_pdata at91sama5d2_config = { > > No, please name it: > > "sama5d2_config" Thanks for your input, but please don't quote the whole mail for those tiny comments. Only the relevant parts, please. Otherwise it is too easy to miss things. Thanks, Wolfram

Re: [PATCH v5 4/6] i2c: at91: add support for new alternative command mode

2015-06-09 Thread Nicolas Ferre
Le 03/06/2015 18:25, Cyrille Pitchen a écrit : > The alternative command mode was introduced to simplify the transmission > of STOP conditions and to solve timing and latency issues around them. > > This mode relies on a new register, the Alternative Command Register, > which must be set at the sa

[PATCH v5 4/6] i2c: at91: add support for new alternative command mode

2015-06-03 Thread Cyrille Pitchen
The alternative command mode was introduced to simplify the transmission of STOP conditions and to solve timing and latency issues around them. This mode relies on a new register, the Alternative Command Register, which must be set at the same time as the Master Mode Register. This new register wa