Re: [PATCH v5 4/6] spmi: pmic_arb: add support for interrupt handling

2014-02-04 Thread Josh Cartwright
On Tue, Feb 04, 2014 at 09:10:45PM +0100, Thomas Gleixner wrote: > On Mon, 3 Feb 2014, Josh Cartwright wrote: > > +static void qpnpint_irq_ack(struct irq_data *d) > > +{ > > + struct spmi_pmic_arb_dev *pa = irq_data_get_irq_chip_data(d); > > + u8 irq = d->hwirq >> 8; > > + u8 apid =

Re: [PATCH v5 4/6] spmi: pmic_arb: add support for interrupt handling

2014-02-04 Thread Thomas Gleixner
On Mon, 3 Feb 2014, Josh Cartwright wrote: > +static void qpnpint_irq_ack(struct irq_data *d) > +{ > + struct spmi_pmic_arb_dev *pa = irq_data_get_irq_chip_data(d); > + u8 irq = d->hwirq >> 8; > + u8 apid = d->hwirq; > + unsigned long flags; > + u8 data; > + > +

Re: [PATCH v5 4/6] spmi: pmic_arb: add support for interrupt handling

2014-02-04 Thread Thomas Gleixner
On Mon, 3 Feb 2014, Josh Cartwright wrote: +static void qpnpint_irq_ack(struct irq_data *d) +{ + struct spmi_pmic_arb_dev *pa = irq_data_get_irq_chip_data(d); + u8 irq = d-hwirq 8; + u8 apid = d-hwirq; + unsigned long flags; + u8 data; + +

Re: [PATCH v5 4/6] spmi: pmic_arb: add support for interrupt handling

2014-02-04 Thread Josh Cartwright
On Tue, Feb 04, 2014 at 09:10:45PM +0100, Thomas Gleixner wrote: On Mon, 3 Feb 2014, Josh Cartwright wrote: +static void qpnpint_irq_ack(struct irq_data *d) +{ + struct spmi_pmic_arb_dev *pa = irq_data_get_irq_chip_data(d); + u8 irq = d-hwirq 8; + u8 apid = d-hwirq; +

[PATCH v5 4/6] spmi: pmic_arb: add support for interrupt handling

2014-02-03 Thread Josh Cartwright
The Qualcomm PMIC Arbiter, in addition to being a basic SPMI controller, also implements interrupt handling for slave devices. Note, this is outside the scope of SPMI, as SPMI leaves interrupt handling completely unspecified. Extend the driver to provide a irq_chip implementation and chained irq

[PATCH v5 4/6] spmi: pmic_arb: add support for interrupt handling

2014-02-03 Thread Josh Cartwright
The Qualcomm PMIC Arbiter, in addition to being a basic SPMI controller, also implements interrupt handling for slave devices. Note, this is outside the scope of SPMI, as SPMI leaves interrupt handling completely unspecified. Extend the driver to provide a irq_chip implementation and chained irq