Re: [PATCH v5 4/7] s390: ap: setup relation betwen KVM and mediated device

2019-03-19 Thread Pierre Morel
On 19/03/2019 16:27, Halil Pasic wrote: On Tue, 19 Mar 2019 15:47:05 +0100 Pierre Morel wrote:    if (matrix_mdev->kvm)    kvm_arch_crypto_clear_masks(matrix_mdev->kvm); This still conditional? Yes, nothing to clear if there is no KVM. Since we have ensured the open only

Re: [PATCH v5 4/7] s390: ap: setup relation betwen KVM and mediated device

2019-03-19 Thread Halil Pasic
On Tue, 19 Mar 2019 15:47:05 +0100 Pierre Morel wrote: > >    if (matrix_mdev->kvm) > >    kvm_arch_crypto_clear_masks(matrix_mdev->kvm); > > This still conditional? > >>> > >>> Yes, nothing to clear if there is no KVM. > >>> > >> > >> Since we have ensured the

Re: [PATCH v5 4/7] s390: ap: setup relation betwen KVM and mediated device

2019-03-19 Thread Pierre Morel
On 19/03/2019 15:23, Pierre Morel wrote: On 19/03/2019 12:54, Halil Pasic wrote: On Tue, 19 Mar 2019 10:38:42 +0100 Pierre Morel wrote: On 15/03/2019 19:15, Halil Pasic wrote: On Wed, 13 Mar 2019 17:05:01 +0100 Pierre Morel wrote: When the mediated device is open we setup the relation with

Re: [PATCH v5 4/7] s390: ap: setup relation betwen KVM and mediated device

2019-03-19 Thread Pierre Morel
On 19/03/2019 12:54, Halil Pasic wrote: On Tue, 19 Mar 2019 10:38:42 +0100 Pierre Morel wrote: On 15/03/2019 19:15, Halil Pasic wrote: On Wed, 13 Mar 2019 17:05:01 +0100 Pierre Morel wrote: When the mediated device is open we setup the relation with KVM unset it when the mediated device is

Re: [PATCH v5 4/7] s390: ap: setup relation betwen KVM and mediated device

2019-03-19 Thread Halil Pasic
On Tue, 19 Mar 2019 10:38:42 +0100 Pierre Morel wrote: > On 15/03/2019 19:15, Halil Pasic wrote: > > On Wed, 13 Mar 2019 17:05:01 +0100 > > Pierre Morel wrote: > > > >> When the mediated device is open we setup the relation with KVM unset it > >> when the mediated device is released. > >> > >>

Re: [PATCH v5 4/7] s390: ap: setup relation betwen KVM and mediated device

2019-03-19 Thread Pierre Morel
On 15/03/2019 19:15, Halil Pasic wrote: On Wed, 13 Mar 2019 17:05:01 +0100 Pierre Morel wrote: When the mediated device is open we setup the relation with KVM unset it when the mediated device is released. We ensure KVM is present on opening of the mediated device. We ensure that KVM survive

Re: [PATCH v5 4/7] s390: ap: setup relation betwen KVM and mediated device

2019-03-15 Thread Halil Pasic
On Wed, 13 Mar 2019 17:05:01 +0100 Pierre Morel wrote: > When the mediated device is open we setup the relation with KVM unset it > when the mediated device is released. > > We ensure KVM is present on opening of the mediated device. > > We ensure that KVM survives the mediated device, and esta

[PATCH v5 4/7] s390: ap: setup relation betwen KVM and mediated device

2019-03-13 Thread Pierre Morel
When the mediated device is open we setup the relation with KVM unset it when the mediated device is released. We ensure KVM is present on opening of the mediated device. We ensure that KVM survives the mediated device, and establish a direct link from KVM to the mediated device to simplify the r