Re: [PATCH v5 4/8] ASoC: wcd9335: add basic controls

Thanks for the review, On 22/01/2019 18:52, Mark Brown wrote: On Thu, Jan 10, 2019 at 03:06:12PM +, Srinivas Kandagatla wrote: +static const char * const wcd9335_ear_pa_gain_text[] = { + "G_6_DB", "G_4P5_DB", "G_3_DB", "G_1P5_DB", + "G_0_DB", "G_M2P5_DB", "UNDEFINED",

Re: [PATCH v5 4/8] ASoC: wcd9335: add basic controls

On Thu, Jan 10, 2019 at 03:06:12PM +, Srinivas Kandagatla wrote: > +static const char * const wcd9335_ear_pa_gain_text[] = { > + "G_6_DB", "G_4P5_DB", "G_3_DB", "G_1P5_DB", > + "G_0_DB", "G_M2P5_DB", "UNDEFINED", "G_M12_DB" > +}; Gains should be controlled with Volume controls, not

[PATCH v5 4/8] ASoC: wcd9335: add basic controls

This patch adds basic controls found in wcd9335 codec. Signed-off-by: Srinivas Kandagatla Reviewed-by: Vinod Koul --- sound/soc/codecs/wcd9335.c | 359 + 1 file changed, 359 insertions(+) diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c