Re: [PATCH v5 5/5] KVM: x86: improve reexecute_instruction

2013-01-11 Thread Marcelo Tosatti
On Fri, Jan 11, 2013 at 02:16:11AM +0800, Xiao Guangrong wrote: > On 01/11/2013 01:30 AM, Marcelo Tosatti wrote: > > On Tue, Jan 08, 2013 at 02:38:36PM +0800, Xiao Guangrong wrote: > >> The current reexecute_instruction can not well detect the failed > >> instruction > >> emulation. It allows gues

Re: [PATCH v5 5/5] KVM: x86: improve reexecute_instruction

2013-01-11 Thread Marcelo Tosatti
On Fri, Jan 11, 2013 at 04:18:22AM +0800, Xiao Guangrong wrote: > On 01/11/2013 03:48 AM, Marcelo Tosatti wrote: > > On Fri, Jan 11, 2013 at 02:05:33AM +0800, Xiao Guangrong wrote: > >> On 01/11/2013 01:26 AM, Marcelo Tosatti wrote: > >>> On Tue, Jan 08, 2013 at 02:38:36PM +0800, Xiao Guangrong wro

Re: [PATCH v5 5/5] KVM: x86: improve reexecute_instruction

2013-01-10 Thread Xiao Guangrong
On 01/11/2013 03:48 AM, Marcelo Tosatti wrote: > On Fri, Jan 11, 2013 at 02:05:33AM +0800, Xiao Guangrong wrote: >> On 01/11/2013 01:26 AM, Marcelo Tosatti wrote: >>> On Tue, Jan 08, 2013 at 02:38:36PM +0800, Xiao Guangrong wrote: The current reexecute_instruction can not well detect the faile

Re: [PATCH v5 5/5] KVM: x86: improve reexecute_instruction

2013-01-10 Thread Marcelo Tosatti
On Fri, Jan 11, 2013 at 02:05:33AM +0800, Xiao Guangrong wrote: > On 01/11/2013 01:26 AM, Marcelo Tosatti wrote: > > On Tue, Jan 08, 2013 at 02:38:36PM +0800, Xiao Guangrong wrote: > >> The current reexecute_instruction can not well detect the failed > >> instruction > >> emulation. It allows gues

Re: [PATCH v5 5/5] KVM: x86: improve reexecute_instruction

2013-01-10 Thread Xiao Guangrong
On 01/11/2013 01:30 AM, Marcelo Tosatti wrote: > On Tue, Jan 08, 2013 at 02:38:36PM +0800, Xiao Guangrong wrote: >> The current reexecute_instruction can not well detect the failed instruction >> emulation. It allows guest to retry all the instructions except it accesses >> on error pfn >> >> For e

Re: [PATCH v5 5/5] KVM: x86: improve reexecute_instruction

2013-01-10 Thread Xiao Guangrong
On 01/11/2013 01:26 AM, Marcelo Tosatti wrote: > On Tue, Jan 08, 2013 at 02:38:36PM +0800, Xiao Guangrong wrote: >> The current reexecute_instruction can not well detect the failed instruction >> emulation. It allows guest to retry all the instructions except it accesses >> on error pfn >> >> For e

Re: [PATCH v5 5/5] KVM: x86: improve reexecute_instruction

2013-01-10 Thread Gleb Natapov
On Thu, Jan 10, 2013 at 03:30:36PM -0200, Marcelo Tosatti wrote: > On Tue, Jan 08, 2013 at 02:38:36PM +0800, Xiao Guangrong wrote: > > The current reexecute_instruction can not well detect the failed instruction > > emulation. It allows guest to retry all the instructions except it accesses > > on

Re: [PATCH v5 5/5] KVM: x86: improve reexecute_instruction

2013-01-10 Thread Marcelo Tosatti
On Tue, Jan 08, 2013 at 02:38:36PM +0800, Xiao Guangrong wrote: > The current reexecute_instruction can not well detect the failed instruction > emulation. It allows guest to retry all the instructions except it accesses > on error pfn > > For example, some cases are nested-write-protect - if the

Re: [PATCH v5 5/5] KVM: x86: improve reexecute_instruction

2013-01-10 Thread Marcelo Tosatti
On Tue, Jan 08, 2013 at 02:38:36PM +0800, Xiao Guangrong wrote: > The current reexecute_instruction can not well detect the failed instruction > emulation. It allows guest to retry all the instructions except it accesses > on error pfn > > For example, some cases are nested-write-protect - if the

[PATCH v5 5/5] KVM: x86: improve reexecute_instruction

2013-01-07 Thread Xiao Guangrong
The current reexecute_instruction can not well detect the failed instruction emulation. It allows guest to retry all the instructions except it accesses on error pfn For example, some cases are nested-write-protect - if the page we want to write is used as PDE but it chains to itself. Under this c