Re: [PATCH v5 5/5] powerpc/perf: split callchain.c by bitness

2019-08-30 Thread Christophe Leroy
Le 30/08/2019 à 09:12, Michal Suchánek a écrit : On Fri, 30 Aug 2019 08:42:25 +0200 Michal Suchánek wrote: On Fri, 30 Aug 2019 06:35:11 + (UTC) Christophe Leroy wrote: On 08/29/2019 10:28 PM, Michal Suchanek wrote: obj-$(CONFIG_PPC_PERF_CTRS) += core-book3s.o bhrb.o diff

Re: [PATCH v5 5/5] powerpc/perf: split callchain.c by bitness

2019-08-30 Thread Michal Suchánek
On Fri, 30 Aug 2019 08:42:25 +0200 Michal Suchánek wrote: > On Fri, 30 Aug 2019 06:35:11 + (UTC) > Christophe Leroy wrote: > > > On 08/29/2019 10:28 PM, Michal Suchanek wrote: > > obj-$(CONFIG_PPC_PERF_CTRS)+= core-book3s.o bhrb.o > > diff --git

Re: [PATCH v5 5/5] powerpc/perf: split callchain.c by bitness

2019-08-30 Thread Michal Suchánek
On Fri, 30 Aug 2019 06:35:11 + (UTC) Christophe Leroy wrote: > On 08/29/2019 10:28 PM, Michal Suchanek wrote: > > Building callchain.c with !COMPAT proved quite ugly with all the > > defines. Splitting out the 32bit and 64bit parts looks better. > > > > Also rewrite current_is_64bit as

Re: [PATCH v5 5/5] powerpc/perf: split callchain.c by bitness

2019-08-30 Thread Christophe Leroy
On 08/29/2019 10:28 PM, Michal Suchanek wrote: > Building callchain.c with !COMPAT proved quite ugly with all the > defines. Splitting out the 32bit and 64bit parts looks better. > > Also rewrite current_is_64bit as common function. No other code change > intended. Nice result. Could look even

[PATCH v5 5/5] powerpc/perf: split callchain.c by bitness

2019-08-29 Thread Michal Suchanek
Building callchain.c with !COMPAT proved quite ugly with all the defines. Splitting out the 32bit and 64bit parts looks better. Also rewrite current_is_64bit as common function. No other code change intended. Signed-off-by: Michal Suchanek --- arch/powerpc/perf/Makefile | 4 +