Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-08-19 Thread Jarkko Sakkinen
On Wed, Aug 19, 2020 at 09:47:18AM +0300, Mike Rapoport wrote: > On Tue, Aug 18, 2020 at 07:30:33PM +0300, Jarkko Sakkinen wrote: > > On Tue, Aug 18, 2020 at 02:51:41PM +0300, Mike Rapoport wrote: > > > On Tue, Aug 18, 2020 at 08:30:29AM +0300, Jarkko Sakkinen wrote: > > > > On Sun, Jul 26, 2020 at

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-08-18 Thread Mike Rapoport
On Tue, Aug 18, 2020 at 07:30:33PM +0300, Jarkko Sakkinen wrote: > On Tue, Aug 18, 2020 at 02:51:41PM +0300, Mike Rapoport wrote: > > On Tue, Aug 18, 2020 at 08:30:29AM +0300, Jarkko Sakkinen wrote: > > > On Sun, Jul 26, 2020 at 11:14:08AM +0300, Mike Rapoport wrote: > > > > > > > > > > I'm not st

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-08-18 Thread Jarkko Sakkinen
On Tue, Aug 18, 2020 at 02:51:41PM +0300, Mike Rapoport wrote: > On Tue, Aug 18, 2020 at 08:30:29AM +0300, Jarkko Sakkinen wrote: > > On Sun, Jul 26, 2020 at 11:14:08AM +0300, Mike Rapoport wrote: > > > > > > > > I'm not still sure that I fully understand this feedback as I don't see > > > > any i

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-08-18 Thread Mike Rapoport
On Tue, Aug 18, 2020 at 08:30:29AM +0300, Jarkko Sakkinen wrote: > On Sun, Jul 26, 2020 at 11:14:08AM +0300, Mike Rapoport wrote: > > > > > > I'm not still sure that I fully understand this feedback as I don't see > > > any inherent and obvious difference to the v4. In that version fallbacks > > >

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-08-17 Thread Jarkko Sakkinen
On Sun, Jul 26, 2020 at 11:14:08AM +0300, Mike Rapoport wrote: > On Sat, Jul 25, 2020 at 06:16:48AM +0300, Jarkko Sakkinen wrote: > > > I've read the observations in the other threads, but this #ifdef > > > jungle is silly, it's a de-facto open coded text_alloc() with a > > > module_alloc() fallb

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-07-29 Thread Masami Hiramatsu
On Wed, 29 Jul 2020 09:13:21 +0300 Ard Biesheuvel wrote: > On Wed, 29 Jul 2020 at 04:51, Masami Hiramatsu wrote: > > > > On Tue, 28 Jul 2020 20:51:08 +0300 > > Ard Biesheuvel wrote: > > > > > On Tue, 28 Jul 2020 at 16:35, Masami Hiramatsu > > > wrote: > > > > > > > > On Tue, 28 Jul 2020 13:56

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-07-28 Thread Ard Biesheuvel
On Wed, 29 Jul 2020 at 04:51, Masami Hiramatsu wrote: > > On Tue, 28 Jul 2020 20:51:08 +0300 > Ard Biesheuvel wrote: > > > On Tue, 28 Jul 2020 at 16:35, Masami Hiramatsu wrote: > > > > > > On Tue, 28 Jul 2020 13:56:43 +0300 > > > Ard Biesheuvel wrote: > > > > > > > On Tue, 28 Jul 2020 at 11:17,

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-07-28 Thread Masami Hiramatsu
On Tue, 28 Jul 2020 20:51:08 +0300 Ard Biesheuvel wrote: > On Tue, 28 Jul 2020 at 16:35, Masami Hiramatsu wrote: > > > > On Tue, 28 Jul 2020 13:56:43 +0300 > > Ard Biesheuvel wrote: > > > > > On Tue, 28 Jul 2020 at 11:17, Masami Hiramatsu > > > wrote: > > > > > Masami or Peter should correct

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-07-28 Thread Ard Biesheuvel
On Tue, 28 Jul 2020 at 16:35, Masami Hiramatsu wrote: > > On Tue, 28 Jul 2020 13:56:43 +0300 > Ard Biesheuvel wrote: > > > On Tue, 28 Jul 2020 at 11:17, Masami Hiramatsu wrote: > > > > Masami or Peter should correct me if I am wrong, but it seems to me > > > > that the way kprobes uses these pag

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-07-28 Thread Masami Hiramatsu
On Tue, 28 Jul 2020 13:56:43 +0300 Ard Biesheuvel wrote: > On Tue, 28 Jul 2020 at 11:17, Masami Hiramatsu wrote: > > > Masami or Peter should correct me if I am wrong, but it seems to me > > > that the way kprobes uses these pages does not require them to be in > > > relative branching range of

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-07-28 Thread Ard Biesheuvel
On Tue, 28 Jul 2020 at 11:17, Masami Hiramatsu wrote: > > On Sun, 26 Jul 2020 19:06:20 +0300 > Ard Biesheuvel wrote: > > > On Sun, 26 Jul 2020 at 11:14, Mike Rapoport wrote: > > > > > > On Sat, Jul 25, 2020 at 06:16:48AM +0300, Jarkko Sakkinen wrote: > > > > On Fri, Jul 24, 2020 at 11:27:46AM +0

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-07-28 Thread Masami Hiramatsu
On Sun, 26 Jul 2020 19:06:20 +0300 Ard Biesheuvel wrote: > On Sun, 26 Jul 2020 at 11:14, Mike Rapoport wrote: > > > > On Sat, Jul 25, 2020 at 06:16:48AM +0300, Jarkko Sakkinen wrote: > > > On Fri, Jul 24, 2020 at 11:27:46AM +0200, Ingo Molnar wrote: > > > > > > > > * Jarkko Sakkinen wrote: > >

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-07-26 Thread Ard Biesheuvel
On Sun, 26 Jul 2020 at 11:14, Mike Rapoport wrote: > > On Sat, Jul 25, 2020 at 06:16:48AM +0300, Jarkko Sakkinen wrote: > > On Fri, Jul 24, 2020 at 11:27:46AM +0200, Ingo Molnar wrote: > > > > > > * Jarkko Sakkinen wrote: > > > > > > > Use text_alloc() and text_free() instead of module_alloc() an

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-07-26 Thread Mike Rapoport
On Sat, Jul 25, 2020 at 06:16:48AM +0300, Jarkko Sakkinen wrote: > On Fri, Jul 24, 2020 at 11:27:46AM +0200, Ingo Molnar wrote: > > > > * Jarkko Sakkinen wrote: > > > > > Use text_alloc() and text_free() instead of module_alloc() and > > > module_memfree() when an arch provides them. > > > > >

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()]

2020-07-24 Thread Jarkko Sakkinen
On Fri, Jul 24, 2020 at 03:16:08PM +0300, Ard Biesheuvel wrote: > On Fri, 24 Jul 2020 at 12:27, Ingo Molnar wrote: > > > > > > * Jarkko Sakkinen wrote: > > > > > Use text_alloc() and text_free() instead of module_alloc() and > > > module_memfree() when an arch provides them. > > > > > > Cc: linux

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-07-24 Thread Jarkko Sakkinen
On Fri, Jul 24, 2020 at 11:27:46AM +0200, Ingo Molnar wrote: > > * Jarkko Sakkinen wrote: > > > Use text_alloc() and text_free() instead of module_alloc() and > > module_memfree() when an arch provides them. > > > > Cc: linux...@kvack.org > > Cc: Andi Kleen > > Cc: Masami Hiramatsu > > Cc: Pe

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-07-24 Thread Jarkko Sakkinen
On Fri, Jul 24, 2020 at 01:27:48PM +0300, Mike Rapoport wrote: > On Fri, Jul 24, 2020 at 08:05:52AM +0300, Jarkko Sakkinen wrote: > > Use text_alloc() and text_free() instead of module_alloc() and > > module_memfree() when an arch provides them. > > > > Cc: linux...@kvack.org > > Cc: Andi Kleen >

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-07-24 Thread Masami Hiramatsu
On Fri, 24 Jul 2020 13:27:48 +0300 Mike Rapoport wrote: > On Fri, Jul 24, 2020 at 08:05:52AM +0300, Jarkko Sakkinen wrote: > > Use text_alloc() and text_free() instead of module_alloc() and > > module_memfree() when an arch provides them. > > > > Cc: linux...@kvack.org > > Cc: Andi Kleen > > Cc

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-07-24 Thread Ard Biesheuvel
On Fri, 24 Jul 2020 at 12:27, Ingo Molnar wrote: > > > * Jarkko Sakkinen wrote: > > > Use text_alloc() and text_free() instead of module_alloc() and > > module_memfree() when an arch provides them. > > > > Cc: linux...@kvack.org > > Cc: Andi Kleen > > Cc: Masami Hiramatsu > > Cc: Peter Zijlstra

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-07-24 Thread Mike Rapoport
On Fri, Jul 24, 2020 at 08:05:52AM +0300, Jarkko Sakkinen wrote: > Use text_alloc() and text_free() instead of module_alloc() and > module_memfree() when an arch provides them. > > Cc: linux...@kvack.org > Cc: Andi Kleen > Cc: Masami Hiramatsu > Cc: Peter Zijlstra > Signed-off-by: Jarkko Sakkin

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-07-24 Thread Ingo Molnar
* Jarkko Sakkinen wrote: > Use text_alloc() and text_free() instead of module_alloc() and > module_memfree() when an arch provides them. > > Cc: linux...@kvack.org > Cc: Andi Kleen > Cc: Masami Hiramatsu > Cc: Peter Zijlstra > Signed-off-by: Jarkko Sakkinen > --- > kernel/kprobes.c | 9 ++

[PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-07-23 Thread Jarkko Sakkinen
Use text_alloc() and text_free() instead of module_alloc() and module_memfree() when an arch provides them. Cc: linux...@kvack.org Cc: Andi Kleen Cc: Masami Hiramatsu Cc: Peter Zijlstra Signed-off-by: Jarkko Sakkinen --- kernel/kprobes.c | 9 + 1 file changed, 9 insertions(+) diff --