Re: [PATCH v5 5/8] watchdog: Simplify update_worker

2015-11-23 Thread Guenter Roeck
Hi Uwe, On 11/23/2015 11:13 PM, Uwe Kleine-König wrote: Hello, On Sun, Nov 22, 2015 at 07:21:02PM -0800, Guenter Roeck wrote: Drop 'cancel' parameter; simply cancel worker unconditionally if not needed. Signed-off-by: Guenter Roeck This is a good change, but given that watchdog_update_work

Re: [PATCH v5 5/8] watchdog: Simplify update_worker

2015-11-23 Thread Uwe Kleine-König
Hello, On Sun, Nov 22, 2015 at 07:21:02PM -0800, Guenter Roeck wrote: > Drop 'cancel' parameter; simply cancel worker unconditionally > if not needed. > > Signed-off-by: Guenter Roeck This is a good change, but given that watchdog_update_worker is introduced in this series it should be squashed

[PATCH v5 5/8] watchdog: Simplify update_worker

2015-11-22 Thread Guenter Roeck
Drop 'cancel' parameter; simply cancel worker unconditionally if not needed. Signed-off-by: Guenter Roeck --- v5: Added patch. drivers/watchdog/watchdog_dev.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/w