Re: [PATCH v5 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-20 Thread Dmitry Torokhov
On Wed, Feb 20, 2013 at 09:24:39AM -0800, Simon Glass wrote: > + > + code = keycodes[pos]; > + new_state = kb_state[col] & (1 << row); > + if (!!new_state != test_bit(code, idev->key)) { > + dev_dbg(ckdev->dev,

[PATCH v5 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-20 Thread Simon Glass
Use the key-matrix layer to interpret key scan information from the EC and inject input based on the FDT-supplied key map. This driver registers itself with the ChromeOS EC driver to perform communications. The matrix-keypad FDT binding is used with a small addition to control ghosting.

[PATCH v5 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-20 Thread Simon Glass
Use the key-matrix layer to interpret key scan information from the EC and inject input based on the FDT-supplied key map. This driver registers itself with the ChromeOS EC driver to perform communications. The matrix-keypad FDT binding is used with a small addition to control ghosting.

Re: [PATCH v5 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-20 Thread Dmitry Torokhov
On Wed, Feb 20, 2013 at 09:24:39AM -0800, Simon Glass wrote: + + code = keycodes[pos]; + new_state = kb_state[col] (1 row); + if (!!new_state != test_bit(code, idev-key)) { + dev_dbg(ckdev-dev, +