Re: [PATCH v5 6/7] powerpc/powernv: generic nest pmu event functions

2015-07-23 Thread Madhavan Srinivasan
On Thursday 23 July 2015 02:34 PM, Michael Ellerman wrote: > On Thu, 2015-07-23 at 12:14 +0530, Madhavan Srinivasan wrote: >> On Wednesday 22 July 2015 10:26 AM, Daniel Axtens wrote: +static void p8_nest_read_counter(struct perf_event *event) +{ + uint64_t *addr; + u64 data

Re: [PATCH v5 6/7] powerpc/powernv: generic nest pmu event functions

2015-07-23 Thread Michael Ellerman
On Thu, 2015-07-23 at 12:14 +0530, Madhavan Srinivasan wrote: > > On Wednesday 22 July 2015 10:26 AM, Daniel Axtens wrote: > >> +static void p8_nest_read_counter(struct perf_event *event) > >> +{ > >> + uint64_t *addr; > >> + u64 data = 0; > > You've got a u64 and a uint64_t, and then... > >> +

Re: [PATCH v5 6/7] powerpc/powernv: generic nest pmu event functions

2015-07-23 Thread Madhavan Srinivasan
On Wednesday 22 July 2015 10:26 AM, Daniel Axtens wrote: >> +static void p8_nest_read_counter(struct perf_event *event) >> +{ >> +uint64_t *addr; >> +u64 data = 0; > You've got a u64 and a uint64_t, and then... >> + >> +addr = (u64 *)event->hw.event_base; > ... you cast to event_base

Re: [PATCH v5 6/7] powerpc/powernv: generic nest pmu event functions

2015-07-23 Thread Madhavan Srinivasan
On Wednesday 22 July 2015 10:26 AM, Daniel Axtens wrote: +static void p8_nest_read_counter(struct perf_event *event) +{ +uint64_t *addr; +u64 data = 0; You've got a u64 and a uint64_t, and then... + +addr = (u64 *)event-hw.event_base; ... you cast to event_base to a u64

Re: [PATCH v5 6/7] powerpc/powernv: generic nest pmu event functions

2015-07-23 Thread Madhavan Srinivasan
On Thursday 23 July 2015 02:34 PM, Michael Ellerman wrote: On Thu, 2015-07-23 at 12:14 +0530, Madhavan Srinivasan wrote: On Wednesday 22 July 2015 10:26 AM, Daniel Axtens wrote: +static void p8_nest_read_counter(struct perf_event *event) +{ + uint64_t *addr; + u64 data = 0; You've got a

Re: [PATCH v5 6/7] powerpc/powernv: generic nest pmu event functions

2015-07-23 Thread Michael Ellerman
On Thu, 2015-07-23 at 12:14 +0530, Madhavan Srinivasan wrote: On Wednesday 22 July 2015 10:26 AM, Daniel Axtens wrote: +static void p8_nest_read_counter(struct perf_event *event) +{ + uint64_t *addr; + u64 data = 0; You've got a u64 and a uint64_t, and then... + + addr = (u64

Re: [PATCH v5 6/7] powerpc/powernv: generic nest pmu event functions

2015-07-21 Thread Daniel Axtens
> +static void p8_nest_read_counter(struct perf_event *event) > +{ > + uint64_t *addr; > + u64 data = 0; You've got a u64 and a uint64_t, and then... > + > + addr = (u64 *)event->hw.event_base; ... you cast to event_base to a u64 pointer, which you assign to a uint64_t pointer. > +

Re: [PATCH v5 6/7] powerpc/powernv: generic nest pmu event functions

2015-07-21 Thread Daniel Axtens
+static void p8_nest_read_counter(struct perf_event *event) +{ + uint64_t *addr; + u64 data = 0; You've got a u64 and a uint64_t, and then... + + addr = (u64 *)event-hw.event_base; ... you cast to event_base to a u64 pointer, which you assign to a uint64_t pointer. + data =

[PATCH v5 6/7] powerpc/powernv: generic nest pmu event functions

2015-07-16 Thread Madhavan Srinivasan
Add set of generic nest pmu related event functions to be used by each nest pmu. Add code to register nest pmus. Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Anton Blanchard Cc: Sukadev Bhattiprolu Cc: Anshuman Khandual Cc: Stephane Eranian Signed-off-by: Madhavan

[PATCH v5 6/7] powerpc/powernv: generic nest pmu event functions

2015-07-16 Thread Madhavan Srinivasan
Add set of generic nest pmu related event functions to be used by each nest pmu. Add code to register nest pmus. Cc: Michael Ellerman m...@ellerman.id.au Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: Anton Blanchard an...@samba.org Cc: Sukadev