Re: [PATCH v5 6/9] ASoC: rockchip: Parse dai links from dts

2017-08-22 Thread jeffy
Hi Donglin, On 08/22/2017 05:08 PM, Donglin Peng wrote: > card->dev = >dev; > platform_set_drvdata(pdev, card); There is no need to call platform_set_drvdata, because devm_snd_soc_register_card will do it. right, will remove it in next version, thanks:)

Re: [PATCH v5 6/9] ASoC: rockchip: Parse dai links from dts

2017-08-22 Thread jeffy
Hi Donglin, On 08/22/2017 05:08 PM, Donglin Peng wrote: > card->dev = >dev; > platform_set_drvdata(pdev, card); There is no need to call platform_set_drvdata, because devm_snd_soc_register_card will do it. right, will remove it in next version, thanks:)

Re: [PATCH v5 6/9] ASoC: rockchip: Parse dai links from dts

2017-08-22 Thread Donglin Peng
On Tue, Aug 22, 2017 at 3:57 PM, Jeffy Chen wrote: > Refactor rockchip_sound_probe, parse dai links from dts instead of > hard coding them. > > Signed-off-by: Jeffy Chen > Reviewed-by: Matthias Kaehlcke > Tested-by:

Re: [PATCH v5 6/9] ASoC: rockchip: Parse dai links from dts

2017-08-22 Thread Donglin Peng
On Tue, Aug 22, 2017 at 3:57 PM, Jeffy Chen wrote: > Refactor rockchip_sound_probe, parse dai links from dts instead of > hard coding them. > > Signed-off-by: Jeffy Chen > Reviewed-by: Matthias Kaehlcke > Tested-by: Matthias Kaehlcke > --- > > Changes in v5: None > Changes in v4: None >

[PATCH v5 6/9] ASoC: rockchip: Parse dai links from dts

2017-08-22 Thread Jeffy Chen
Refactor rockchip_sound_probe, parse dai links from dts instead of hard coding them. Signed-off-by: Jeffy Chen Reviewed-by: Matthias Kaehlcke Tested-by: Matthias Kaehlcke --- Changes in v5: None Changes in v4: None Changes in

[PATCH v5 6/9] ASoC: rockchip: Parse dai links from dts

2017-08-22 Thread Jeffy Chen
Refactor rockchip_sound_probe, parse dai links from dts instead of hard coding them. Signed-off-by: Jeffy Chen Reviewed-by: Matthias Kaehlcke Tested-by: Matthias Kaehlcke --- Changes in v5: None Changes in v4: None Changes in v3: Use compatible to match audio codecs -- Suggested-by