Re: [PATCH v5 7/7] pwm: pca9685: Restrict period change for prescaler users

2020-12-17 Thread Sven Van Asbroeck
On Thu, Dec 17, 2020 at 1:07 PM Clemens Gruber wrote: > > As always, great review! Thank you! > My pleasure, it's great to help out. And thanks, you're the one doing all the hard work :)

Re: [PATCH v5 7/7] pwm: pca9685: Restrict period change for prescaler users

2020-12-17 Thread Clemens Gruber
Hi Sven, On Wed, Dec 16, 2020 at 11:03:39PM -0500, Sven Van Asbroeck wrote: > Hi Clemens, see below. > > On Wed, Dec 16, 2020 at 7:53 AM Clemens Gruber > wrote: > > > > Previously, the last used PWM channel could change the global prescale > > setting, even if other channels were already in

Re: [PATCH v5 7/7] pwm: pca9685: Restrict period change for prescaler users

2020-12-16 Thread Sven Van Asbroeck
Hi Clemens, see below. On Wed, Dec 16, 2020 at 7:53 AM Clemens Gruber wrote: > > Previously, the last used PWM channel could change the global prescale > setting, even if other channels were already in use. > > Fix it by only allowing the first user of the prescaler to change the > global

[PATCH v5 7/7] pwm: pca9685: Restrict period change for prescaler users

2020-12-15 Thread Clemens Gruber
Previously, the last used PWM channel could change the global prescale setting, even if other channels were already in use. Fix it by only allowing the first user of the prescaler to change the global chip-wide prescale setting. If there is more than one channel in use, the prescale settings