Re: [PATCH v6] iio: accel: mma8452: improvements to handle multiple events

2017-09-10 Thread harinath Nampally
> Alright, I didn't test it but I kind of like it now. The one minor > naming issue I had pointed out before is mentioned below. But if that's > no issue for Jon: > Reviewed-by: Martin Kepplinger Martin, Thanks a lot for the review. > btw, Harianath: Would you point me to the imx6ul eval board yo

Re: [PATCH v6] iio: accel: mma8452: improvements to handle multiple events

2017-09-10 Thread harinath Nampally
> I stripped the version change stuff from the commit message - they > should have been below the --- Useful during review, but generally > not worth retaining once we have accepted it. I didn't know that, thanks for letting me know. Next time I will keep that in mind. Thanks, Hari On Sun, Sep

Re: [PATCH v6] iio: accel: mma8452: improvements to handle multiple events

2017-09-10 Thread Jonathan Cameron
On Sun, 10 Sep 2017 08:36:43 +0200 Martin Kepplinger wrote: > On 2017-09-09 21:56, Harinath Nampally wrote: > > This driver supports multiple devices like mma8653, > > mma8652, mma8452, mma8453 and fxls8471. Almost all > > these devices have more than one event. > > > > Current d

Re: [PATCH v6] iio: accel: mma8452: improvements to handle multiple events

2017-09-09 Thread Martin Kepplinger
On 2017-09-09 21:56, Harinath Nampally wrote: > This driver supports multiple devices like mma8653, > mma8652, mma8452, mma8453 and fxls8471. Almost all > these devices have more than one event. > > Current driver design hardcodes the event specific > information, so only one e

[PATCH v6] iio: accel: mma8452: improvements to handle multiple events

2017-09-09 Thread Harinath Nampally
This driver supports multiple devices like mma8653, mma8652, mma8452, mma8453 and fxls8471. Almost all these devices have more than one event. Current driver design hardcodes the event specific information, so only one event can be supported by this driver at any given time