Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-08 Thread Philippe Ombredanne
On Fri, Feb 9, 2018 at 1:35 AM, Joe Perches wrote: > On Fri, 2018-02-02 at 13:18 -0800, Joe Perches wrote: >> On Fri, 2018-02-02 at 09:40 -0600, Rob Herring wrote: >> > Add SPDX license tag check based on the rules defined in >> > Documentation/process/license-rules.rst. To

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-08 Thread Philippe Ombredanne
On Fri, Feb 9, 2018 at 1:35 AM, Joe Perches wrote: > On Fri, 2018-02-02 at 13:18 -0800, Joe Perches wrote: >> On Fri, 2018-02-02 at 09:40 -0600, Rob Herring wrote: >> > Add SPDX license tag check based on the rules defined in >> > Documentation/process/license-rules.rst. To summarize, SPDX

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-08 Thread Joe Perches
On Fri, 2018-02-02 at 13:18 -0800, Joe Perches wrote: > On Fri, 2018-02-02 at 09:40 -0600, Rob Herring wrote: > > Add SPDX license tag check based on the rules defined in > > Documentation/process/license-rules.rst. To summarize, SPDX license tags > > should be on the 1st line (or 2nd line in

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-08 Thread Joe Perches
On Fri, 2018-02-02 at 13:18 -0800, Joe Perches wrote: > On Fri, 2018-02-02 at 09:40 -0600, Rob Herring wrote: > > Add SPDX license tag check based on the rules defined in > > Documentation/process/license-rules.rst. To summarize, SPDX license tags > > should be on the 1st line (or 2nd line in

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-08 Thread Philippe Ombredanne
Joe, On Thu, Feb 8, 2018 at 6:24 PM, Joe Perches wrote: > On Thu, 2018-02-08 at 15:35 +0100, Philippe Ombredanne wrote: >> However checking that licenses ids are known and listed in the kernel >> doc is essential IMHO to avoid drift and insulate the kernel from SPDX >> updates.

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-08 Thread Philippe Ombredanne
Joe, On Thu, Feb 8, 2018 at 6:24 PM, Joe Perches wrote: > On Thu, 2018-02-08 at 15:35 +0100, Philippe Ombredanne wrote: >> However checking that licenses ids are known and listed in the kernel >> doc is essential IMHO to avoid drift and insulate the kernel from SPDX >> updates. Case in point

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-08 Thread Joe Perches
On Thu, 2018-02-08 at 15:35 +0100, Philippe Ombredanne wrote: > However checking that licenses ids are known and listed in the kernel > doc is essential IMHO to avoid drift and insulate the kernel from SPDX > updates. Case in point the new SPDX "GPL-2.0-only" is NOT what was > documented by tglx

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-08 Thread Joe Perches
On Thu, 2018-02-08 at 15:35 +0100, Philippe Ombredanne wrote: > However checking that licenses ids are known and listed in the kernel > doc is essential IMHO to avoid drift and insulate the kernel from SPDX > updates. Case in point the new SPDX "GPL-2.0-only" is NOT what was > documented by tglx

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-08 Thread Philippe Ombredanne
On Sat, Feb 3, 2018 at 2:41 PM, Igor Stoppa wrote: > > > On 02/02/18 21:06, Joe Perches wrote: >> On Fri, 2018-02-02 at 12:27 -0600, Rob Herring wrote: >>> On Fri, Feb 2, 2018 at 9:49 AM, Igor Stoppa wrote: On 02/02/18 17:40, Rob Herring

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-08 Thread Philippe Ombredanne
On Sat, Feb 3, 2018 at 2:41 PM, Igor Stoppa wrote: > > > On 02/02/18 21:06, Joe Perches wrote: >> On Fri, 2018-02-02 at 12:27 -0600, Rob Herring wrote: >>> On Fri, Feb 2, 2018 at 9:49 AM, Igor Stoppa wrote: On 02/02/18 17:40, Rob Herring wrote: > Add SPDX license tag check based on the

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-08 Thread Philippe Ombredanne
Kate, On Fri, Feb 2, 2018 at 9:18 PM, Kate Stewart wrote: > This is the new way to represent GPLv2 only, as described above. > While the GPL-2.0 and GPL-2.0+ notation is still valid, it is deprecated > in the latest version, so transitioning existing over time will

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-08 Thread Philippe Ombredanne
Kate, On Fri, Feb 2, 2018 at 9:18 PM, Kate Stewart wrote: > This is the new way to represent GPLv2 only, as described above. > While the GPL-2.0 and GPL-2.0+ notation is still valid, it is deprecated > in the latest version, so transitioning existing over time will probably > be needed. So I

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-08 Thread Philippe Ombredanne
even On Fri, Feb 2, 2018 at 8:06 PM, Joe Perches wrote: > On Fri, 2018-02-02 at 12:27 -0600, Rob Herring wrote: >> On Fri, Feb 2, 2018 at 9:49 AM, Igor Stoppa wrote: >> > On 02/02/18 17:40, Rob Herring wrote: >> > > Add SPDX license tag check based on

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-08 Thread Philippe Ombredanne
even On Fri, Feb 2, 2018 at 8:06 PM, Joe Perches wrote: > On Fri, 2018-02-02 at 12:27 -0600, Rob Herring wrote: >> On Fri, Feb 2, 2018 at 9:49 AM, Igor Stoppa wrote: >> > On 02/02/18 17:40, Rob Herring wrote: >> > > Add SPDX license tag check based on the rules defined in >> > >> > Shouldn't it

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-03 Thread Igor Stoppa
On 02/02/18 21:06, Joe Perches wrote: > On Fri, 2018-02-02 at 12:27 -0600, Rob Herring wrote: >> On Fri, Feb 2, 2018 at 9:49 AM, Igor Stoppa wrote: >>> On 02/02/18 17:40, Rob Herring wrote: Add SPDX license tag check based on the rules defined in >>> >>> Shouldn't

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-03 Thread Igor Stoppa
On 02/02/18 21:06, Joe Perches wrote: > On Fri, 2018-02-02 at 12:27 -0600, Rob Herring wrote: >> On Fri, Feb 2, 2018 at 9:49 AM, Igor Stoppa wrote: >>> On 02/02/18 17:40, Rob Herring wrote: Add SPDX license tag check based on the rules defined in >>> >>> Shouldn't it also check that the

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-02 Thread Joe Perches
On Fri, 2018-02-02 at 09:40 -0600, Rob Herring wrote: > Add SPDX license tag check based on the rules defined in > Documentation/process/license-rules.rst. To summarize, SPDX license tags > should be on the 1st line (or 2nd line in scripts) using the appropriate > comment style for the file type.

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-02 Thread Joe Perches
On Fri, 2018-02-02 at 09:40 -0600, Rob Herring wrote: > Add SPDX license tag check based on the rules defined in > Documentation/process/license-rules.rst. To summarize, SPDX license tags > should be on the 1st line (or 2nd line in scripts) using the appropriate > comment style for the file type.

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-02 Thread Joe Perches
On Fri, 2018-02-02 at 14:57 -0600, Rob Herring wrote: > On Fri, Feb 2, 2018 at 1:06 PM, Joe Perches wrote: [] > > Right now, there are many missing licenses > > that are already used by various existing > > SPDX-License-Identifier: entries. > > > > APACHE-2.0 > > Given that

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-02 Thread Joe Perches
On Fri, 2018-02-02 at 14:57 -0600, Rob Herring wrote: > On Fri, Feb 2, 2018 at 1:06 PM, Joe Perches wrote: [] > > Right now, there are many missing licenses > > that are already used by various existing > > SPDX-License-Identifier: entries. > > > > APACHE-2.0 > > Given that Apache 2.0 is not

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-02 Thread Rob Herring
On Fri, Feb 2, 2018 at 1:06 PM, Joe Perches wrote: > On Fri, 2018-02-02 at 12:27 -0600, Rob Herring wrote: >> On Fri, Feb 2, 2018 at 9:49 AM, Igor Stoppa wrote: >> > On 02/02/18 17:40, Rob Herring wrote: >> > > Add SPDX license tag check based on the

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-02 Thread Rob Herring
On Fri, Feb 2, 2018 at 1:06 PM, Joe Perches wrote: > On Fri, 2018-02-02 at 12:27 -0600, Rob Herring wrote: >> On Fri, Feb 2, 2018 at 9:49 AM, Igor Stoppa wrote: >> > On 02/02/18 17:40, Rob Herring wrote: >> > > Add SPDX license tag check based on the rules defined in >> > >> > Shouldn't it also

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-02 Thread Joe Perches
On Fri, 2018-02-02 at 14:18 -0600, Kate Stewart wrote: > On Fri, Feb 2, 2018 at 1:06 PM, Joe Perches wrote: > > > On Fri, 2018-02-02 at 12:27 -0600, Rob Herring wrote: > > > On Fri, Feb 2, 2018 at 9:49 AM, Igor Stoppa > > > > wrote: > > > > On 02/02/18

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-02 Thread Joe Perches
On Fri, 2018-02-02 at 14:18 -0600, Kate Stewart wrote: > On Fri, Feb 2, 2018 at 1:06 PM, Joe Perches wrote: > > > On Fri, 2018-02-02 at 12:27 -0600, Rob Herring wrote: > > > On Fri, Feb 2, 2018 at 9:49 AM, Igor Stoppa > > > > wrote: > > > > On 02/02/18 17:40, Rob Herring wrote: > > > > > Add

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-02 Thread Joe Perches
On Fri, 2018-02-02 at 12:27 -0600, Rob Herring wrote: > On Fri, Feb 2, 2018 at 9:49 AM, Igor Stoppa wrote: > > On 02/02/18 17:40, Rob Herring wrote: > > > Add SPDX license tag check based on the rules defined in > > > > Shouldn't it also check that the license is

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-02 Thread Joe Perches
On Fri, 2018-02-02 at 12:27 -0600, Rob Herring wrote: > On Fri, Feb 2, 2018 at 9:49 AM, Igor Stoppa wrote: > > On 02/02/18 17:40, Rob Herring wrote: > > > Add SPDX license tag check based on the rules defined in > > > > Shouldn't it also check that the license is compatible? > > > > Perhaps we

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-02 Thread Rob Herring
On Fri, Feb 2, 2018 at 9:49 AM, Igor Stoppa wrote: > On 02/02/18 17:40, Rob Herring wrote: >> Add SPDX license tag check based on the rules defined in > > Shouldn't it also check that the license is compatible? > Perhaps we shouldn't try to script legal advice. > [...] >

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-02 Thread Rob Herring
On Fri, Feb 2, 2018 at 9:49 AM, Igor Stoppa wrote: > On 02/02/18 17:40, Rob Herring wrote: >> Add SPDX license tag check based on the rules defined in > > Shouldn't it also check that the license is compatible? > Perhaps we shouldn't try to script legal advice. > [...] > >> +

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-02 Thread Jonathan Corbet
On Fri, 2 Feb 2018 17:12:46 +0100 Greg Kroah-Hartman wrote: > > What is the correct/acceptable license for documentation? > > Creative Commons? AFAIK GPL is for source code. > > > > Googling didn't bring the wished-for enlightenment. > > It depends on what you

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-02 Thread Jonathan Corbet
On Fri, 2 Feb 2018 17:12:46 +0100 Greg Kroah-Hartman wrote: > > What is the correct/acceptable license for documentation? > > Creative Commons? AFAIK GPL is for source code. > > > > Googling didn't bring the wished-for enlightenment. > > It depends on what you want to allow the documentation

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-02 Thread Greg Kroah-Hartman
On Fri, Feb 02, 2018 at 05:49:20PM +0200, Igor Stoppa wrote: > On 02/02/18 17:40, Rob Herring wrote: > > Add SPDX license tag check based on the rules defined in > > Shouldn't it also check that the license is compatible? Baby steps please :) > [...] > > > + } elsif

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-02 Thread Greg Kroah-Hartman
On Fri, Feb 02, 2018 at 05:49:20PM +0200, Igor Stoppa wrote: > On 02/02/18 17:40, Rob Herring wrote: > > Add SPDX license tag check based on the rules defined in > > Shouldn't it also check that the license is compatible? Baby steps please :) > [...] > > > + } elsif

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-02 Thread Igor Stoppa
On 02/02/18 17:40, Rob Herring wrote: > Add SPDX license tag check based on the rules defined in Shouldn't it also check that the license is compatible? [...] > + } elsif ($realfile =~ /\.rst$/) { > + $comment = '..'; What is the

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-02 Thread Igor Stoppa
On 02/02/18 17:40, Rob Herring wrote: > Add SPDX license tag check based on the rules defined in Shouldn't it also check that the license is compatible? [...] > + } elsif ($realfile =~ /\.rst$/) { > + $comment = '..'; What is the

[PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-02 Thread Rob Herring
Add SPDX license tag check based on the rules defined in Documentation/process/license-rules.rst. To summarize, SPDX license tags should be on the 1st line (or 2nd line in scripts) using the appropriate comment style for the file type. Cc: Andy Whitcroft Cc: Joe Perches

[PATCH v6] checkpatch.pl: Add SPDX license tag check

2018-02-02 Thread Rob Herring
Add SPDX license tag check based on the rules defined in Documentation/process/license-rules.rst. To summarize, SPDX license tags should be on the 1st line (or 2nd line in scripts) using the appropriate comment style for the file type. Cc: Andy Whitcroft Cc: Joe Perches Cc: Thomas Gleixner Cc: