Re: [PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

David Miller writes: > From: Måns Rullgård > Date: Mon, 16 Nov 2015 20:59:18 + > >> Anything else? > > Sorry, when I find one problem I give you the feedback for that > and move on to the 100s of other patches I have in my queue. Some people prefer to comment on more than one issue, if

Re: [PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

From: Måns Rullgård Date: Mon, 16 Nov 2015 20:59:18 + > Anything else? Sorry, when I find one problem I give you the feedback for that and move on to the 100s of other patches I have in my queue. Or would you like me to devote all of my time to just your driver instead of taking everyone's

Re: [PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

David Miller writes: > From: Mans Rullgard > Date: Mon, 16 Nov 2015 18:23:35 + > >> +static int nb8800_alloc_rx(struct net_device *dev, int i, bool napi) > > "i" is passed in as a signed int here, but: > >> +static void nb8800_receive(struct net_device *dev, unsigned i, unsigned len) > ...

Re: [PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

From: Mans Rullgard Date: Mon, 16 Nov 2015 18:23:35 + > +static int nb8800_alloc_rx(struct net_device *dev, int i, bool napi) "i" is passed in as a signed int here, but: > +static void nb8800_receive(struct net_device *dev, unsigned i, unsigned len) ... > + err =

[PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

This adds a driver for the Aurora VLSI NB8800 Ethernet controller. It is an almost complete rewrite of a driver originally found in a Sigma Designs 2.6.22 tree. Signed-off-by: Mans Rullgard --- Changes: - Use napi_gro_receive() - Ignore xmit_more if using last tx descriptor - Perform tx cleanup

[PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

This adds a driver for the Aurora VLSI NB8800 Ethernet controller. It is an almost complete rewrite of a driver originally found in a Sigma Designs 2.6.22 tree. Signed-off-by: Mans Rullgard --- Changes: - Use napi_gro_receive() - Ignore xmit_more if using last tx descriptor -

Re: [PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

From: Måns Rullgård Date: Mon, 16 Nov 2015 20:59:18 + > Anything else? Sorry, when I find one problem I give you the feedback for that and move on to the 100s of other patches I have in my queue. Or would you like me to devote all of my time to just your driver instead of

Re: [PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

From: Mans Rullgard Date: Mon, 16 Nov 2015 18:23:35 + > +static int nb8800_alloc_rx(struct net_device *dev, int i, bool napi) "i" is passed in as a signed int here, but: > +static void nb8800_receive(struct net_device *dev, unsigned i, unsigned len) ... > + err

Re: [PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

David Miller writes: > From: Måns Rullgård > Date: Mon, 16 Nov 2015 20:59:18 + > >> Anything else? > > Sorry, when I find one problem I give you the feedback for that > and move on to the 100s of other patches I have in my queue. Some people prefer to

Re: [PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

David Miller writes: > From: Mans Rullgard > Date: Mon, 16 Nov 2015 18:23:35 + > >> +static int nb8800_alloc_rx(struct net_device *dev, int i, bool napi) > > "i" is passed in as a signed int here, but: > >> +static void nb8800_receive(struct net_device