Re: [PATCH v6] perf: __kmod_path__parse: deal with kernel module names in '[]' correctly.

2015-05-28 Thread Namhyung Kim
Hi, Sorry for being late, I forgot about this email.. On Tue, Apr 21, 2015 at 05:28:51PM +0800, Wang Nan wrote: > On 2015/4/21 13:16, Namhyung Kim wrote: > > Hi Wang, > > > > On Tue, Apr 21, 2015 at 03:33:10AM +, Wang Nan wrote: > >> Before patch ba92732e9808df679ddf75c5ea1c0caae6d7dce2

Re: [PATCH v6] perf: __kmod_path__parse: deal with kernel module names in '[]' correctly.

2015-05-28 Thread Jiri Olsa
On Tue, Apr 21, 2015 at 03:33:10AM +, Wang Nan wrote: > Before patch ba92732e9808df679ddf75c5ea1c0caae6d7dce2 ('perf kmaps: > Check kmaps to make code more robust'), perf report and perf annotate > will segfault if trace data contains kernel module information like > this: sry I've lost track

Re: [PATCH v6] perf: __kmod_path__parse: deal with kernel module names in '[]' correctly.

2015-05-28 Thread Wangnan (F)
Ping? Does anyone still concern this patch? On 2015/5/28 15:23, www-data wrote: Before patch ba92732e9808df679ddf75c5ea1c0caae6d7dce2 ('perf kmaps: Check kmaps to make code more robust'), perf report and perf annotate will segfault if trace data contains kernel module information like this:

Re: [PATCH v6] perf: __kmod_path__parse: deal with kernel module names in '[]' correctly.

2015-05-28 Thread Namhyung Kim
Hi, Sorry for being late, I forgot about this email.. On Tue, Apr 21, 2015 at 05:28:51PM +0800, Wang Nan wrote: On 2015/4/21 13:16, Namhyung Kim wrote: Hi Wang, On Tue, Apr 21, 2015 at 03:33:10AM +, Wang Nan wrote: Before patch ba92732e9808df679ddf75c5ea1c0caae6d7dce2 ('perf

Re: [PATCH v6] perf: __kmod_path__parse: deal with kernel module names in '[]' correctly.

2015-05-28 Thread Jiri Olsa
On Tue, Apr 21, 2015 at 03:33:10AM +, Wang Nan wrote: Before patch ba92732e9808df679ddf75c5ea1c0caae6d7dce2 ('perf kmaps: Check kmaps to make code more robust'), perf report and perf annotate will segfault if trace data contains kernel module information like this: sry I've lost track on

Re: [PATCH v6] perf: __kmod_path__parse: deal with kernel module names in '[]' correctly.

2015-05-28 Thread Wangnan (F)
Ping? Does anyone still concern this patch? On 2015/5/28 15:23, www-data wrote: Before patch ba92732e9808df679ddf75c5ea1c0caae6d7dce2 ('perf kmaps: Check kmaps to make code more robust'), perf report and perf annotate will segfault if trace data contains kernel module information like this:

Re: [PATCH v6] perf: __kmod_path__parse: deal with kernel module names in '[]' correctly.

2015-04-21 Thread Wang Nan
On 2015/4/21 13:16, Namhyung Kim wrote: > Hi Wang, > > On Tue, Apr 21, 2015 at 03:33:10AM +, Wang Nan wrote: >> Before patch ba92732e9808df679ddf75c5ea1c0caae6d7dce2 ('perf kmaps: >> Check kmaps to make code more robust'), perf report and perf annotate >> will segfault if trace data contains

Re: [PATCH v6] perf: __kmod_path__parse: deal with kernel module names in '[]' correctly.

2015-04-21 Thread Wang Nan
On 2015/4/21 13:16, Namhyung Kim wrote: Hi Wang, On Tue, Apr 21, 2015 at 03:33:10AM +, Wang Nan wrote: Before patch ba92732e9808df679ddf75c5ea1c0caae6d7dce2 ('perf kmaps: Check kmaps to make code more robust'), perf report and perf annotate will segfault if trace data contains kernel

Re: [PATCH v6] perf: __kmod_path__parse: deal with kernel module names in '[]' correctly.

2015-04-20 Thread Namhyung Kim
Hi Wang, On Tue, Apr 21, 2015 at 03:33:10AM +, Wang Nan wrote: > Before patch ba92732e9808df679ddf75c5ea1c0caae6d7dce2 ('perf kmaps: > Check kmaps to make code more robust'), perf report and perf annotate > will segfault if trace data contains kernel module information like > this: > > #

[PATCH v6] perf: __kmod_path__parse: deal with kernel module names in '[]' correctly.

2015-04-20 Thread Wang Nan
Before patch ba92732e9808df679ddf75c5ea1c0caae6d7dce2 ('perf kmaps: Check kmaps to make code more robust'), perf report and perf annotate will segfault if trace data contains kernel module information like this: # perf report -D -i ./perf.data ... 0 0 0x188 [0x50]: PERF_RECORD_MMAP -1/0:

[PATCH v6] perf: __kmod_path__parse: deal with kernel module names in '[]' correctly.

2015-04-20 Thread Wang Nan
Before patch ba92732e9808df679ddf75c5ea1c0caae6d7dce2 ('perf kmaps: Check kmaps to make code more robust'), perf report and perf annotate will segfault if trace data contains kernel module information like this: # perf report -D -i ./perf.data ... 0 0 0x188 [0x50]: PERF_RECORD_MMAP -1/0:

Re: [PATCH v6] perf: __kmod_path__parse: deal with kernel module names in '[]' correctly.

2015-04-20 Thread Namhyung Kim
Hi Wang, On Tue, Apr 21, 2015 at 03:33:10AM +, Wang Nan wrote: Before patch ba92732e9808df679ddf75c5ea1c0caae6d7dce2 ('perf kmaps: Check kmaps to make code more robust'), perf report and perf annotate will segfault if trace data contains kernel module information like this: # perf