Re: [PATCH v6] perf annotate: Fix sample events lost in stdio mode

2021-03-22 Thread Yang Jihong
Hello, On 2021/3/18 14:13, Namhyung Kim wrote: Hello, On Wed, Mar 17, 2021 at 6:44 PM Yang Jihong wrote: In hist__find_annotations function, since different hist_entry may point to same symbol, we free notes->src to signal already processed this symbol in stdio mode; when annotate, entry wi

Re: [PATCH v6] perf annotate: Fix sample events lost in stdio mode

2021-03-19 Thread Yang Jihong
On 2021/3/18 14:13, Namhyung Kim wrote: Hello, On Wed, Mar 17, 2021 at 6:44 PM Yang Jihong wrote: In hist__find_annotations function, since different hist_entry may point to same symbol, we free notes->src to signal already processed this symbol in stdio mode; when annotate, entry will sk

Re: [PATCH v6] perf annotate: Fix sample events lost in stdio mode

2021-03-17 Thread Namhyung Kim
Hello, On Wed, Mar 17, 2021 at 6:44 PM Yang Jihong wrote: > > In hist__find_annotations function, since different hist_entry may point to > same > symbol, we free notes->src to signal already processed this symbol in stdio > mode; > when annotate, entry will skipped if notes->src is NULL to avo

[PATCH v6] perf annotate: Fix sample events lost in stdio mode

2021-03-17 Thread Yang Jihong
In hist__find_annotations function, since different hist_entry may point to same symbol, we free notes->src to signal already processed this symbol in stdio mode; when annotate, entry will skipped if notes->src is NULL to avoid repeated output. However, there is a problem, for example, run the f