Re: [linux-sunxi] Re: [PATCH v6] sun4i-codec: Add FM, Line and Mic inputs

2015-12-21 Thread Danny Milosavljevic
Hi Maxime, On Fri, 18 Dec 2015 11:19:43 +0100 Maxime Ripard wrote: > It would also be a good idea to open a github issue on allwinner's > documentation repo to make them know that the register name doesn't > match between the register list and the register documentations. I did that now. the

Re: [linux-sunxi] Re: [PATCH v6] sun4i-codec: Add FM, Line and Mic inputs

2015-12-18 Thread Maxime Ripard
On Wed, Dec 16, 2015 at 11:30:51PM +0100, Danny Milosavljevic wrote: > Hi Maxime, > > On Wed, 16 Dec 2015 11:47:36 +0100 > Maxime Ripard wrote: > > > > Because SUN4I_CODEC_AC_MIC_PHONE_CAL is sun7i-specific. > > > > Yet, you're using it in both cases (A10 vs A20). > > Yes. I'm trying to keep c

Re: [linux-sunxi] Re: [PATCH v6] sun4i-codec: Add FM, Line and Mic inputs

2015-12-16 Thread Danny Milosavljevic
Hi Maxime, On Wed, 16 Dec 2015 11:47:36 +0100 Maxime Ripard wrote: > > Because SUN4I_CODEC_AC_MIC_PHONE_CAL is sun7i-specific. > > Yet, you're using it in both cases (A10 vs A20). Yes. I'm trying to keep complexity and duplication down. I figured it wouldn't be bad to have unused registers in

Re: [PATCH v6] sun4i-codec: Add FM, Line and Mic inputs

2015-12-16 Thread Maxime Ripard
Hi, On Tue, Dec 15, 2015 at 02:52:08AM +0100, Danny Milosavljevic wrote: > Hi Maxime, > > On Sun, 13 Dec 2015 21:58:39 +0100 > Maxime Ripard wrote: > > > This is not the branch you should be basing your patch on. This is an > > ASoC patch, base it on the ASoC tree. > > Okay, will do. To the br

Re: [PATCH v6] sun4i-codec: Add FM, Line and Mic inputs

2015-12-14 Thread Danny Milosavljevic
Hi Maxime, On Sun, 13 Dec 2015 21:58:39 +0100 Maxime Ripard wrote: > This is not the branch you should be basing your patch on. This is an > ASoC patch, base it on the ASoC tree. Okay, will do. To the branch "sunxi-next" in , right? [...] > > -static const struct regmap_config sun4i_codec_reg

Re: [PATCH v6] sun4i-codec: Add FM, Line and Mic inputs

2015-12-13 Thread Maxime Ripard
Hi, On Wed, Dec 09, 2015 at 11:55:30PM +0100, Danny Milosavljevic wrote: > Add inputs to sun4i-codec: > - FM-in Left and Right > - Line-in Left and Right > - Mic1-in > - Mic2-in > > Signed-off-by: Danny Milosavljevic > Tested-by: Danny Milosavljevic (ONLY ON A20!) We'd expect you to have t

[PATCH v6] sun4i-codec: Add FM, Line and Mic inputs

2015-12-09 Thread Danny Milosavljevic
Add inputs to sun4i-codec: - FM-in Left and Right - Line-in Left and Right - Mic1-in - Mic2-in Signed-off-by: Danny Milosavljevic Tested-by: Danny Milosavljevic (ONLY ON A20!) --- Hi, this is the sixth version of the patch that adds inputs to sun4i-codec. Changes compared to v5 are: - Mic