On 26. 03. 19, 11:17, Andy Shevchenko wrote:
>> @@ -199,7 +203,10 @@ static void qrk_serial_exit_dma(struct lpss8250 *lpss)
>>
>> if (!param->dma_dev)
>> return;
>> +
>> dw_dma_remove(>dma_chip);
>> +
>> +iounmap(>dma_chip->regs);
>
> This is a bit fragile form of
On Mon, Mar 25, 2019 at 05:21:46PM -0500, Aditya Pakki wrote:
> pci_ioremap_bar could fail. The patch returns in case of failure to
> acquire IOMEM. It also releases the acquired resource in the exit path.
Thanks for an update.
One comment below.
After addressing it, take mine
Reviewed-by: Andy
pci_ioremap_bar could fail. The patch returns in case of failure to
acquire IOMEM. It also releases the acquired resource in the exit path.
Signed-off-by: Aditya Pakki
---
v5: change pci_iounmap to iounmap to pass kbuild errors in other arch
v4: Missed resource release in dma_probe failure.
v3:
3 matches
Mail list logo