Re: [PATCH v6] x86: Avoid pr_cont() in show_opcodes().

2018-07-19 Thread Peter Zijlstra
On Thu, Jul 19, 2018 at 10:53:03PM +0900, Tetsuo Handa wrote: > + if (probe_kernel_read(opcodes, rip - PROLOGUE_SIZE, OPCODE_BUFSIZE)) > + printk("%sCode: Bad RIP value.\n", loglvl); > + else > + printk("%sCode: %" __stringify(PROLOGUE_SIZE) "ph <%02x> %" > +

Re: [PATCH v6] x86: Avoid pr_cont() in show_opcodes().

2018-07-19 Thread Peter Zijlstra
On Thu, Jul 19, 2018 at 10:53:03PM +0900, Tetsuo Handa wrote: > + if (probe_kernel_read(opcodes, rip - PROLOGUE_SIZE, OPCODE_BUFSIZE)) > + printk("%sCode: Bad RIP value.\n", loglvl); > + else > + printk("%sCode: %" __stringify(PROLOGUE_SIZE) "ph <%02x> %" > +

[PATCH v6] x86: Avoid pr_cont() in show_opcodes().

2018-07-19 Thread Tetsuo Handa
From: Rasmus Villemoes Since syzbot is confused by concurrent printk() messages [1], this patch changes show_opcodes() to use %ph format string. When we start adding prefix to each line of printk() output, we will be able to handle concurrent printk() messages. [1]

[PATCH v6] x86: Avoid pr_cont() in show_opcodes().

2018-07-19 Thread Tetsuo Handa
From: Rasmus Villemoes Since syzbot is confused by concurrent printk() messages [1], this patch changes show_opcodes() to use %ph format string. When we start adding prefix to each line of printk() output, we will be able to handle concurrent printk() messages. [1]