On 2016/1/20 19:46, Mark Brown wrote: > On Wed, Jan 20, 2016 at 11:51:27AM +0800, chenfeng wrote: > >> I will change it like this: >> bindings: regulator: hi655x: Document for hi655x regulator driver > > As we discussed previously I'd expected something more like: > > regulator: hi655x: Document for hi655x regulator driver > ok >> arm64: dts: hisilicon: Add hi655x pmic dts node > > That's what I'd expect. > >> Have you also reviewed the regulator driver code? I changed it to >> of_match and regulators_node without opening code. > > Not yet. >