Re: [PATCH v6 0/5] Introduce the Counter character device interface

2020-12-21 Thread David Lechner
On 12/20/20 3:44 PM, William Breathitt Gray wrote: On Sun, Dec 13, 2020 at 05:15:14PM -0600, David Lechner wrote: On 11/22/20 2:29 PM, William Breathitt Gray wrote: 1. Should standard Counter component data types be defined as u8 or u32? Many standard Counter component types such COUNTER

Re: [PATCH v6 0/5] Introduce the Counter character device interface

2020-12-20 Thread William Breathitt Gray
On Sun, Dec 13, 2020 at 05:15:14PM -0600, David Lechner wrote: > On 11/22/20 2:29 PM, William Breathitt Gray wrote: > > > > 1. Should standard Counter component data types be defined as u8 or u32? > > > > Many standard Counter component types such COUNTER_COMP_SIGNAL_LEVEL > > have standa

Re: [PATCH v6 0/5] Introduce the Counter character device interface

2020-12-13 Thread David Lechner
On 11/22/20 2:29 PM, William Breathitt Gray wrote: 1. Should standard Counter component data types be defined as u8 or u32? Many standard Counter component types such COUNTER_COMP_SIGNAL_LEVEL have standard values defined (e.g. COUNTER_SIGNAL_LEVEL_LOW and COUNTER_SIGNAL_LEVEL_HIGH)

[PATCH v6 0/5] Introduce the Counter character device interface

2020-11-22 Thread William Breathitt Gray
Changes in v6: - Consolidated the value member of struct counter_event down to a single u64; u64 should be capable of representing all component values - Removed extension width sysfs attributes; no longer needed when value is always u64 - Implemented COUNTER_COMPONENT_DUMMY to allow ti