Re: [PATCH v6 0/8] block: prepare for multipage bvecs

2016-06-09 Thread Ming Lei
On Fri, Jun 10, 2016 at 12:06 AM, Jens Axboe wrote: > On 05/30/2016 07:34 AM, Ming Lei wrote: >> >> Hi, >> >> Interests[1] have been shown in multipage bvecs, so this patchset >> try to prepare for the support and do two things: >> >> 1) the 1st 4 patches use bvec iterator to

Re: [PATCH v6 0/8] block: prepare for multipage bvecs

2016-06-09 Thread Ming Lei
On Fri, Jun 10, 2016 at 12:06 AM, Jens Axboe wrote: > On 05/30/2016 07:34 AM, Ming Lei wrote: >> >> Hi, >> >> Interests[1] have been shown in multipage bvecs, so this patchset >> try to prepare for the support and do two things: >> >> 1) the 1st 4 patches use bvec iterator to implement

Re: [PATCH v6 0/8] block: prepare for multipage bvecs

2016-06-09 Thread Jens Axboe
On 05/30/2016 07:34 AM, Ming Lei wrote: Hi, Interests[1] have been shown in multipage bvecs, so this patchset try to prepare for the support and do two things: 1) the 1st 4 patches use bvec iterator to implement iterate_bvec(), then we can drop the non-standard way for iterating bvec, which

Re: [PATCH v6 0/8] block: prepare for multipage bvecs

2016-06-09 Thread Jens Axboe
On 05/30/2016 07:34 AM, Ming Lei wrote: Hi, Interests[1] have been shown in multipage bvecs, so this patchset try to prepare for the support and do two things: 1) the 1st 4 patches use bvec iterator to implement iterate_bvec(), then we can drop the non-standard way for iterating bvec, which

Re: [PATCH v6 0/8] block: prepare for multipage bvecs

2016-06-01 Thread Ming Lei
On Wed, Jun 1, 2016 at 9:51 PM, Mike Snitzer wrote: > On Wed, Jun 01 2016 at 9:44am -0400, > Christoph Hellwig wrote: > >> On Wed, Jun 01, 2016 at 08:38:41PM +0800, Ming Lei wrote: >> > > be dm-crypt.c. Maybe you've identified some indirect use of >> > >

Re: [PATCH v6 0/8] block: prepare for multipage bvecs

2016-06-01 Thread Ming Lei
On Wed, Jun 1, 2016 at 9:51 PM, Mike Snitzer wrote: > On Wed, Jun 01 2016 at 9:44am -0400, > Christoph Hellwig wrote: > >> On Wed, Jun 01, 2016 at 08:38:41PM +0800, Ming Lei wrote: >> > > be dm-crypt.c. Maybe you've identified some indirect use of >> > > BIO_MAX_SIZE? >> > >> > I mean the

Re: [PATCH v6 0/8] block: prepare for multipage bvecs

2016-06-01 Thread Christoph Hellwig
On Wed, Jun 01, 2016 at 09:51:51AM -0400, Mike Snitzer wrote: > So should I not push this type of fix to Linus now? I was going to send > the above commit and this one to him this week: >

Re: [PATCH v6 0/8] block: prepare for multipage bvecs

2016-06-01 Thread Christoph Hellwig
On Wed, Jun 01, 2016 at 09:51:51AM -0400, Mike Snitzer wrote: > So should I not push this type of fix to Linus now? I was going to send > the above commit and this one to him this week: >

Re: [PATCH v6 0/8] block: prepare for multipage bvecs

2016-06-01 Thread Mike Snitzer
On Wed, Jun 01 2016 at 9:53am -0400, Hannes Reinecke wrote: > On 06/01/2016 03:43 PM, Christoph Hellwig wrote: > > These patches look good on their own. They might be an easier sell > > just as bio cleanups :) > > Fully agree. I've seen (some) improvements with those patches, so

Re: [PATCH v6 0/8] block: prepare for multipage bvecs

2016-06-01 Thread Mike Snitzer
On Wed, Jun 01 2016 at 9:53am -0400, Hannes Reinecke wrote: > On 06/01/2016 03:43 PM, Christoph Hellwig wrote: > > These patches look good on their own. They might be an easier sell > > just as bio cleanups :) > > Fully agree. I've seen (some) improvements with those patches, so > I'd prefer

Re: [PATCH v6 0/8] block: prepare for multipage bvecs

2016-06-01 Thread Hannes Reinecke
On 06/01/2016 03:43 PM, Christoph Hellwig wrote: > These patches look good on their own. They might be an easier sell > just as bio cleanups :) Fully agree. I've seen (some) improvements with those patches, so I'd prefer to have them. You can add: Tested-by: Hannes Reinecke

Re: [PATCH v6 0/8] block: prepare for multipage bvecs

2016-06-01 Thread Hannes Reinecke
On 06/01/2016 03:43 PM, Christoph Hellwig wrote: > These patches look good on their own. They might be an easier sell > just as bio cleanups :) Fully agree. I've seen (some) improvements with those patches, so I'd prefer to have them. You can add: Tested-by: Hannes Reinecke Cheers, Hannes

Re: [PATCH v6 0/8] block: prepare for multipage bvecs

2016-06-01 Thread Mike Snitzer
On Wed, Jun 01 2016 at 9:44am -0400, Christoph Hellwig wrote: > On Wed, Jun 01, 2016 at 08:38:41PM +0800, Ming Lei wrote: > > > be dm-crypt.c. Maybe you've identified some indirect use of > > > BIO_MAX_SIZE? > > > > I mean the recently introduced BIO_MAX_SIZE in -next

Re: [PATCH v6 0/8] block: prepare for multipage bvecs

2016-06-01 Thread Mike Snitzer
On Wed, Jun 01 2016 at 9:44am -0400, Christoph Hellwig wrote: > On Wed, Jun 01, 2016 at 08:38:41PM +0800, Ming Lei wrote: > > > be dm-crypt.c. Maybe you've identified some indirect use of > > > BIO_MAX_SIZE? > > > > I mean the recently introduced BIO_MAX_SIZE in -next tree: > > > >

Re: [PATCH v6 0/8] block: prepare for multipage bvecs

2016-06-01 Thread Christoph Hellwig
On Wed, Jun 01, 2016 at 08:38:41PM +0800, Ming Lei wrote: > > be dm-crypt.c. Maybe you've identified some indirect use of > > BIO_MAX_SIZE? > > I mean the recently introduced BIO_MAX_SIZE in -next tree: > >

Re: [PATCH v6 0/8] block: prepare for multipage bvecs

2016-06-01 Thread Christoph Hellwig
On Wed, Jun 01, 2016 at 08:38:41PM +0800, Ming Lei wrote: > > be dm-crypt.c. Maybe you've identified some indirect use of > > BIO_MAX_SIZE? > > I mean the recently introduced BIO_MAX_SIZE in -next tree: > >

Re: [PATCH v6 0/8] block: prepare for multipage bvecs

2016-06-01 Thread Christoph Hellwig
These patches look good on their own. They might be an easier sell just as bio cleanups :)

Re: [PATCH v6 0/8] block: prepare for multipage bvecs

2016-06-01 Thread Christoph Hellwig
These patches look good on their own. They might be an easier sell just as bio cleanups :)

Re: [PATCH v6 0/8] block: prepare for multipage bvecs

2016-06-01 Thread Ming Lei
On Tue, May 31, 2016 at 11:53 PM, Mike Snitzer wrote: > On Mon, May 30 2016 at 9:34am -0400, > Ming Lei wrote: > >> >> Hi, >> >> Interests[1] have been shown in multipage bvecs, so this patchset >> try to prepare for the support and do two things: >>

Re: [PATCH v6 0/8] block: prepare for multipage bvecs

2016-06-01 Thread Ming Lei
On Tue, May 31, 2016 at 11:53 PM, Mike Snitzer wrote: > On Mon, May 30 2016 at 9:34am -0400, > Ming Lei wrote: > >> >> Hi, >> >> Interests[1] have been shown in multipage bvecs, so this patchset >> try to prepare for the support and do two things: >> >> 1) the 1st 4 patches use bvec iterator to

Re: [PATCH v6 0/8] block: prepare for multipage bvecs

2016-05-31 Thread Mike Snitzer
On Mon, May 30 2016 at 9:34am -0400, Ming Lei wrote: > > Hi, > > Interests[1] have been shown in multipage bvecs, so this patchset > try to prepare for the support and do two things: > > 1) the 1st 4 patches use bvec iterator to implement iterate_bvec(), > then we can

Re: [PATCH v6 0/8] block: prepare for multipage bvecs

2016-05-31 Thread Mike Snitzer
On Mon, May 30 2016 at 9:34am -0400, Ming Lei wrote: > > Hi, > > Interests[1] have been shown in multipage bvecs, so this patchset > try to prepare for the support and do two things: > > 1) the 1st 4 patches use bvec iterator to implement iterate_bvec(), > then we can drop the non-standard

[PATCH v6 0/8] block: prepare for multipage bvecs

2016-05-30 Thread Ming Lei
Hi, Interests[1] have been shown in multipage bvecs, so this patchset try to prepare for the support and do two things: 1) the 1st 4 patches use bvec iterator to implement iterate_bvec(), then we can drop the non-standard way for iterating bvec, which can be thought as a good cleanup for

[PATCH v6 0/8] block: prepare for multipage bvecs

2016-05-30 Thread Ming Lei
Hi, Interests[1] have been shown in multipage bvecs, so this patchset try to prepare for the support and do two things: 1) the 1st 4 patches use bvec iterator to implement iterate_bvec(), then we can drop the non-standard way for iterating bvec, which can be thought as a good cleanup for