Re: [PATCH v6 01/11] powerpc/powernv: Data structure and macros definitions

2017-04-06 Thread Stewart Smith
Madhavan Srinivasan writes: > +#define IMC_MAX_CHIPS32 > +#define IMC_MAX_PMUS 32 The max chips and PMUs we'd be able to work out from the device tre though, right? We could just allocate the correct amount of memory on boot. We

Re: [PATCH v6 01/11] powerpc/powernv: Data structure and macros definitions

2017-04-06 Thread Stewart Smith
Madhavan Srinivasan writes: > +#define IMC_MAX_CHIPS32 > +#define IMC_MAX_PMUS 32 The max chips and PMUs we'd be able to work out from the device tre though, right? We could just allocate the correct amount of memory on boot. We may hot plug/unplug CPUs,

Re: [PATCH v6 01/11] powerpc/powernv: Data structure and macros definitions

2017-04-06 Thread Stewart Smith
Madhavan Srinivasan writes: > From: Hemant Kumar > > Create new header file "imc-pmu.h" to add the data structures > and macros needed for IMC pmu support. > > Signed-off-by: Anju T Sudhakar > Signed-off-by: Hemant

Re: [PATCH v6 01/11] powerpc/powernv: Data structure and macros definitions

2017-04-06 Thread Stewart Smith
Madhavan Srinivasan writes: > From: Hemant Kumar > > Create new header file "imc-pmu.h" to add the data structures > and macros needed for IMC pmu support. > > Signed-off-by: Anju T Sudhakar > Signed-off-by: Hemant Kumar > Signed-off-by: Madhavan Srinivasan > --- >

Re: [PATCH v6 01/11] powerpc/powernv: Data structure and macros definitions

2017-04-04 Thread Madhavan Srinivasan
On Tuesday 04 April 2017 07:18 AM, Daniel Axtens wrote: Hi, +#define IMC_MAX_CHIPS 32 +#define IMC_MAX_PMUS 32 +#define IMC_MAX_PMU_NAME_LEN 256 I've noticed this is used as both the maximum length for event names and event value strings. Would

Re: [PATCH v6 01/11] powerpc/powernv: Data structure and macros definitions

2017-04-04 Thread Madhavan Srinivasan
On Tuesday 04 April 2017 07:18 AM, Daniel Axtens wrote: Hi, +#define IMC_MAX_CHIPS 32 +#define IMC_MAX_PMUS 32 +#define IMC_MAX_PMU_NAME_LEN 256 I've noticed this is used as both the maximum length for event names and event value strings. Would

Re: [PATCH v6 01/11] powerpc/powernv: Data structure and macros definitions

2017-04-03 Thread Daniel Axtens
Hi, > +#define IMC_MAX_CHIPS32 > +#define IMC_MAX_PMUS 32 > +#define IMC_MAX_PMU_NAME_LEN 256 I've noticed this is used as both the maximum length for event names and event value strings. Would another name suit better? > + > +#define

Re: [PATCH v6 01/11] powerpc/powernv: Data structure and macros definitions

2017-04-03 Thread Daniel Axtens
Hi, > +#define IMC_MAX_CHIPS32 > +#define IMC_MAX_PMUS 32 > +#define IMC_MAX_PMU_NAME_LEN 256 I've noticed this is used as both the maximum length for event names and event value strings. Would another name suit better? > + > +#define

[PATCH v6 01/11] powerpc/powernv: Data structure and macros definitions

2017-04-03 Thread Madhavan Srinivasan
From: Hemant Kumar Create new header file "imc-pmu.h" to add the data structures and macros needed for IMC pmu support. Signed-off-by: Anju T Sudhakar Signed-off-by: Hemant Kumar Signed-off-by: Madhavan Srinivasan

[PATCH v6 01/11] powerpc/powernv: Data structure and macros definitions

2017-04-03 Thread Madhavan Srinivasan
From: Hemant Kumar Create new header file "imc-pmu.h" to add the data structures and macros needed for IMC pmu support. Signed-off-by: Anju T Sudhakar Signed-off-by: Hemant Kumar Signed-off-by: Madhavan Srinivasan --- arch/powerpc/include/asm/imc-pmu.h | 68