On Mon, Sep 02, 2019 at 10:43:03AM +0200, Pavel Machek wrote:
> > > > Rather than they didn't run "gdb" or "pahole" and change it by mistake.
> > >
> > > I think Christoph is not right here.
> > >
> > > Using external tools for validation is extra work
> > > when necessary for understanding the
Hi Christoph,
On Thu, Aug 29, 2019 at 02:59:54AM -0700, Christoph Hellwig wrote:
[]
>
> > +static bool erofs_inode_is_data_compressed(unsigned int datamode)
> > +{
> > + if (datamode == EROFS_INODE_FLAT_COMPRESSION)
> > + return true;
> > + return datamode ==
On Thu, Aug 29, 2019 at 06:32:53PM +0800, Gao Xiang wrote:
> I can fix it up as you like but I still cannot get
> what is critical issues here.
The problem is that the whole codebase is way substandard quality,
looking a lot like Linux code from 20 years ago. Yes, we already have
plenty of code
Hi Christoph,
On Thu, Aug 29, 2019 at 02:59:54AM -0700, Christoph Hellwig wrote:
> > --- /dev/null
> > +++ b/fs/erofs/erofs_fs.h
> > @@ -0,0 +1,316 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only OR Apache-2.0 */
> > +/*
> > + * linux/fs/erofs/erofs_fs.h
>
> Please remove the pointless file
4 matches
Mail list logo
