Re: [PATCH v6 02/12] Driver core: Unified device properties interface for platform firmware

2014-11-04 Thread Rafael J. Wysocki
On Tuesday, November 04, 2014 05:01:04 PM Grant Likely wrote: > On Mon, Nov 3, 2014 at 10:04 PM, Rafael J. Wysocki wrote: > >> I also found that this parser code doesn't correctly handle malformed > >> (unterminated) string properties. It will overflow. The existing > >> functions have the same

Re: [PATCH v6 02/12] Driver core: Unified device properties interface for platform firmware

2014-11-04 Thread Grant Likely
On Mon, Nov 3, 2014 at 10:04 PM, Rafael J. Wysocki wrote: >> I also found that this parser code doesn't correctly handle malformed >> (unterminated) string properties. It will overflow. The existing >> functions have the same problem, so it isn't something that you've >> added. I've got a fix,

[Update][PATCH v6 02/12] Driver core: Unified device properties interface for platform firmware

2014-11-04 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Add a uniform interface by which device drivers can request device properties from the platform firmware by providing a property name and the corresponding data type. The purpose of it is to help to write portable code that won't depend on any particular platform

Re: [PATCH v6 02/12] Driver core: Unified device properties interface for platform firmware

2014-11-04 Thread Rafael J. Wysocki
On Tuesday, November 04, 2014 03:51:12 PM Grant Likely wrote: > On Tue, 21 Oct 2014 23:15:50 +0200 > , "Rafael J. Wysocki" > wrote: > > From: "Rafael J. Wysocki" > > > > Add a uniform interface by which device drivers can request device > > properties from the platform firmware by providing a

Re: [PATCH v6 02/12] Driver core: Unified device properties interface for platform firmware

2014-11-04 Thread Grant Likely
On Tue, 21 Oct 2014 23:15:50 +0200 , "Rafael J. Wysocki" wrote: > From: "Rafael J. Wysocki" > > Add a uniform interface by which device drivers can request device > properties from the platform firmware by providing a property name > and the corresponding data type. The purpose of it is to

Re: [PATCH v6 02/12] Driver core: Unified device properties interface for platform firmware

2014-11-04 Thread Grant Likely
On Tue, 21 Oct 2014 23:15:50 +0200 , Rafael J. Wysocki r...@rjwysocki.net wrote: From: Rafael J. Wysocki rafael.j.wyso...@intel.com Add a uniform interface by which device drivers can request device properties from the platform firmware by providing a property name and the corresponding

Re: [PATCH v6 02/12] Driver core: Unified device properties interface for platform firmware

2014-11-04 Thread Rafael J. Wysocki
On Tuesday, November 04, 2014 03:51:12 PM Grant Likely wrote: On Tue, 21 Oct 2014 23:15:50 +0200 , Rafael J. Wysocki r...@rjwysocki.net wrote: From: Rafael J. Wysocki rafael.j.wyso...@intel.com Add a uniform interface by which device drivers can request device properties from the

[Update][PATCH v6 02/12] Driver core: Unified device properties interface for platform firmware

2014-11-04 Thread Rafael J. Wysocki
From: Rafael J. Wysocki rafael.j.wyso...@intel.com Add a uniform interface by which device drivers can request device properties from the platform firmware by providing a property name and the corresponding data type. The purpose of it is to help to write portable code that won't depend on any

Re: [PATCH v6 02/12] Driver core: Unified device properties interface for platform firmware

2014-11-04 Thread Grant Likely
On Mon, Nov 3, 2014 at 10:04 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: I also found that this parser code doesn't correctly handle malformed (unterminated) string properties. It will overflow. The existing functions have the same problem, so it isn't something that you've added. I've got

Re: [PATCH v6 02/12] Driver core: Unified device properties interface for platform firmware

2014-11-04 Thread Rafael J. Wysocki
On Tuesday, November 04, 2014 05:01:04 PM Grant Likely wrote: On Mon, Nov 3, 2014 at 10:04 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: I also found that this parser code doesn't correctly handle malformed (unterminated) string properties. It will overflow. The existing functions have

Re: [PATCH v6 02/12] Driver core: Unified device properties interface for platform firmware

2014-11-03 Thread Rafael J. Wysocki
On Monday, November 03, 2014 03:40:08 PM Grant Likely wrote: > Hi Rafael, Hi, > While reviewing and testing these patches I ran into serious bugs in > the string parsers (in both the existing code and the new functions > here). It took me a number of days, but I've got a fix now which I'll > be

Re: [PATCH v6 02/12] Driver core: Unified device properties interface for platform firmware

2014-11-03 Thread Grant Likely
Hi Rafael, While reviewing and testing these patches I ran into serious bugs in the string parsers (in both the existing code and the new functions here). It took me a number of days, but I've got a fix now which I'll be posting shortly and I want to get into mainline right away. I'll cc you when

Re: [PATCH v6 02/12] Driver core: Unified device properties interface for platform firmware

2014-11-03 Thread Grant Likely
Hi Rafael, While reviewing and testing these patches I ran into serious bugs in the string parsers (in both the existing code and the new functions here). It took me a number of days, but I've got a fix now which I'll be posting shortly and I want to get into mainline right away. I'll cc you when

Re: [PATCH v6 02/12] Driver core: Unified device properties interface for platform firmware

2014-11-03 Thread Rafael J. Wysocki
On Monday, November 03, 2014 03:40:08 PM Grant Likely wrote: Hi Rafael, Hi, While reviewing and testing these patches I ran into serious bugs in the string parsers (in both the existing code and the new functions here). It took me a number of days, but I've got a fix now which I'll be

[PATCH v6 02/12] Driver core: Unified device properties interface for platform firmware

2014-10-21 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Add a uniform interface by which device drivers can request device properties from the platform firmware by providing a property name and the corresponding data type. The purpose of it is to help to write portable code that won't depend on any particular platform

[PATCH v6 02/12] Driver core: Unified device properties interface for platform firmware

2014-10-21 Thread Rafael J. Wysocki
From: Rafael J. Wysocki rafael.j.wyso...@intel.com Add a uniform interface by which device drivers can request device properties from the platform firmware by providing a property name and the corresponding data type. The purpose of it is to help to write portable code that won't depend on any