Re: [PATCH v6 02/13] arm64: add pointer authentication register bits

2018-12-11 Thread Will Deacon
On Mon, Dec 10, 2018 at 07:54:25PM +, Kristina Martsenko wrote: > On 09/12/2018 14:24, Richard Henderson wrote: > > On 12/7/18 12:39 PM, Kristina Martsenko wrote: > >> #define SCTLR_ELx_DSSBS (1UL << 44) > >> +#define SCTLR_ELx_ENIA(1 << 31) > > > > 1U or 1UL lest you produce signed -0x

Re: [PATCH v6 02/13] arm64: add pointer authentication register bits

2018-12-10 Thread Kristina Martsenko
On 09/12/2018 14:24, Richard Henderson wrote: > On 12/7/18 12:39 PM, Kristina Martsenko wrote: >> #define SCTLR_ELx_DSSBS (1UL << 44) >> +#define SCTLR_ELx_ENIA (1 << 31) > > 1U or 1UL lest you produce signed -0x8000. Thanks, this was setting all SCTLR bits above 31 as well... Now f

Re: [PATCH v6 02/13] arm64: add pointer authentication register bits

2018-12-09 Thread Richard Henderson
On 12/7/18 12:39 PM, Kristina Martsenko wrote: > #define SCTLR_ELx_DSSBS (1UL << 44) > +#define SCTLR_ELx_ENIA (1 << 31) 1U or 1UL lest you produce signed -0x8000. Otherwise, Reviewed-by: Richard Henderson r~

[PATCH v6 02/13] arm64: add pointer authentication register bits

2018-12-07 Thread Kristina Martsenko
From: Mark Rutland The ARMv8.3 pointer authentication extension adds: * New fields in ID_AA64ISAR1 to report the presence of pointer authentication functionality. * New control bits in SCTLR_ELx to enable this functionality. * New system registers to hold the keys necessary for this functi