Re: [PATCH v6 04/12] misc: at25: Make use of device property API

2014-11-04 Thread Mika Westerberg
On Tue, Nov 04, 2014 at 05:19:02PM +0100, Rafael J. Wysocki wrote: > > > I think np->name is "at25" in this case? The binding file > > > Documentation/devicetree/bindings/misc/at25.txt also has the same name. > > > > > > Are you OK, if we add something like below to the changelog? > > > > > > In a

Re: [PATCH v6 04/12] misc: at25: Make use of device property API

2014-11-04 Thread Rafael J. Wysocki
On Tuesday, November 04, 2014 03:04:54 PM Grant Likely wrote: > On Tue, Nov 4, 2014 at 2:38 PM, Mika Westerberg > wrote: > > On Tue, Nov 04, 2014 at 02:18:26PM +, Grant Likely wrote: > >> > - strncpy(chip->name, np->name, sizeof(chip->name)); > >> > + strncpy(chip->name, "at25", sizeof(chi

Re: [PATCH v6 04/12] misc: at25: Make use of device property API

2014-11-04 Thread Grant Likely
On Tue, Nov 4, 2014 at 2:38 PM, Mika Westerberg wrote: > On Tue, Nov 04, 2014 at 02:18:26PM +, Grant Likely wrote: >> > - strncpy(chip->name, np->name, sizeof(chip->name)); >> > + strncpy(chip->name, "at25", sizeof(chip->name)); >> >> This line changes behaviour of the driver. It's possibl

Re: [PATCH v6 04/12] misc: at25: Make use of device property API

2014-11-04 Thread Mika Westerberg
On Tue, Nov 04, 2014 at 02:18:26PM +, Grant Likely wrote: > > - strncpy(chip->name, np->name, sizeof(chip->name)); > > + strncpy(chip->name, "at25", sizeof(chip->name)); > > This line changes behaviour of the driver. It's possibly not a problem, > but it should be commented on and whether

Re: [PATCH v6 04/12] misc: at25: Make use of device property API

2014-11-04 Thread Grant Likely
On Tue, 21 Oct 2014 23:19:56 +0200 , "Rafael J. Wysocki" wrote: > From: Mika Westerberg > > Make use of device property API in this driver so that both DT and ACPI > based systems can use this driver. > > Signed-off-by: Mika Westerberg > Signed-off-by: Rafael J. Wysocki > --- > drivers/misc

[PATCH v6 04/12] misc: at25: Make use of device property API

2014-10-21 Thread Rafael J. Wysocki
From: Mika Westerberg Make use of device property API in this driver so that both DT and ACPI based systems can use this driver. Signed-off-by: Mika Westerberg Signed-off-by: Rafael J. Wysocki --- drivers/misc/eeprom/at25.c | 34 +- 1 file changed, 13 inserti