Re: [PATCH v6 04/13] usb: dwc3: Add splitdisable quirk for Hisilicon Kirin Soc

2020-09-08 Thread Thinh Nguyen
Felipe Balbi wrote: > Hi, > > Mauro Carvalho Chehab writes: I tested here, together with the Hikey 970 phy RFC patches I sent last week. Without this patch, the USB HID driver receives -EPROTO from submitted URBs, causing it to enter into an endless reset cycle on eve

Re: [PATCH v6 04/13] usb: dwc3: Add splitdisable quirk for Hisilicon Kirin Soc

2020-09-07 Thread Mauro Carvalho Chehab
Em Tue, 08 Sep 2020 09:09:46 +0300 Felipe Balbi escreveu: > >> Why does it affect only Hikey kirin? > > > > As John Stultz didn't re-submit this one (and looking at the DT > > between Kirin 960 and 970 from the original Kernel 4.9 official > > drivers), I suspect that only Kirin 970 requires t

Re: [PATCH v6 04/13] usb: dwc3: Add splitdisable quirk for Hisilicon Kirin Soc

2020-09-07 Thread Mauro Carvalho Chehab
Em Mon, 07 Sep 2020 17:04:31 +0300 Felipe Balbi escreveu: > >> static const struct dev_pm_ops dwc3_dev_pm_ops = { > >>SET_SYSTEM_SLEEP_PM_OPS(dwc3_suspend, dwc3_resume) > >> + .complete = dwc3_complete, > > why is this done on complete? Why can't it be done at the end of > dwc3_resume()?

Re: [PATCH v6 04/13] usb: dwc3: Add splitdisable quirk for Hisilicon Kirin Soc

2020-09-07 Thread Felipe Balbi
Hi, Mauro Carvalho Chehab writes: >> > I tested here, together with the Hikey 970 phy RFC patches I sent >> > last week. >> > >> > Without this patch, the USB HID driver receives -EPROTO from >> > submitted URBs, causing it to enter into an endless reset cycle >> > on every 500 ms, at the hid_io

Re: [PATCH v6 04/13] usb: dwc3: Add splitdisable quirk for Hisilicon Kirin Soc

2020-09-07 Thread Felipe Balbi
Hi Mauro, Mauro Carvalho Chehab writes: > Hi Felipe/Greg, > > What's the status of this patch? to be frank, I don't think I have this in my inbox anymore. > I tested here, together with the Hikey 970 phy RFC patches I sent > last week. > > Without this patch, the USB HID driver receives -EPR

Re: [PATCH v6 04/13] usb: dwc3: Add splitdisable quirk for Hisilicon Kirin Soc

2020-09-07 Thread Mauro Carvalho Chehab
Em Mon, 07 Sep 2020 17:04:31 +0300 Felipe Balbi escreveu: > Hi Mauro, > > Mauro Carvalho Chehab writes: > > > Hi Felipe/Greg, > > > > What's the status of this patch? > > to be frank, I don't think I have this in my inbox anymore. > > > I tested here, together with the Hikey 970 phy RFC p

Re: [PATCH v6 04/13] usb: dwc3: Add splitdisable quirk for Hisilicon Kirin Soc

2020-09-07 Thread Mauro Carvalho Chehab
Hi Felipe/Greg, What's the status of this patch? I tested here, together with the Hikey 970 phy RFC patches I sent last week. Without this patch, the USB HID driver receives -EPROTO from submitted URBs, causing it to enter into an endless reset cycle on every 500 ms, at the hid_io_error() logic