Re: [PATCH v6 05/11] powerpc/perf: Generic imc pmu event functions

2017-04-03 Thread Daniel Axtens
Hi, So a major complaint I have is that you're changing prototypes of functions from earlier patches. This makes my life a lot harder: I get my head around what a function is and does and then suddenly the prototype changes, the behaviour changes, and I have to re-evaluate everything I thought I

[PATCH v6 05/11] powerpc/perf: Generic imc pmu event functions

2017-04-03 Thread Madhavan Srinivasan
From: Hemant Kumar Since, the IMC counters' data are periodically fed to a memory location, the functions to read/update, start/stop, add/del can be generic and can be used by all IMC PMU units. This patch adds a set of generic imc pmu related event functions to be used by each imc pmu unit. Ad