Re: [PATCH v6 05/19] mm: memcontrol: decouple reference counting from page accounting

2020-06-18 Thread Shakeel Butt
On Mon, Jun 8, 2020 at 4:07 PM Roman Gushchin wrote: > > From: Johannes Weiner > > The reference counting of a memcg is currently coupled directly to how > many 4k pages are charged to it. This doesn't work well with Roman's > new slab controller, which maintains pools of objects and doesn't

Re: [PATCH v6 05/19] mm: memcontrol: decouple reference counting from page accounting

2020-06-18 Thread Shakeel Butt
On Thu, Jun 18, 2020 at 6:08 PM Roman Gushchin wrote: > > On Thu, Jun 18, 2020 at 07:55:35AM -0700, Shakeel Butt wrote: > > Not sure if my email went through, so, re-sending. > > > > On Mon, Jun 8, 2020 at 4:07 PM Roman Gushchin wrote: > > > > > > From: Johannes Weiner > > > > > [...] > > > @@

Re: [PATCH v6 05/19] mm: memcontrol: decouple reference counting from page accounting

2020-06-18 Thread Roman Gushchin
On Thu, Jun 18, 2020 at 07:55:35AM -0700, Shakeel Butt wrote: > Not sure if my email went through, so, re-sending. > > On Mon, Jun 8, 2020 at 4:07 PM Roman Gushchin wrote: > > > > From: Johannes Weiner > > > [...] > > @@ -3003,13 +3004,16 @@ void __memcg_kmem_uncharge_page(struct page *page, >

Re: [PATCH v6 05/19] mm: memcontrol: decouple reference counting from page accounting

2020-06-18 Thread Roman Gushchin
On Thu, Jun 18, 2020 at 07:55:35AM -0700, Shakeel Butt wrote: > Not sure if my email went through, so, re-sending. No, I've got it, jut was busy with the other stuff. > > On Mon, Jun 8, 2020 at 4:07 PM Roman Gushchin wrote: > > > > From: Johannes Weiner > > > [...] > > @@ -3003,13 +3004,16 @@

Re: [PATCH v6 05/19] mm: memcontrol: decouple reference counting from page accounting

2020-06-18 Thread Shakeel Butt
Not sure if my email went through, so, re-sending. On Mon, Jun 8, 2020 at 4:07 PM Roman Gushchin wrote: > > From: Johannes Weiner > [...] > @@ -3003,13 +3004,16 @@ void __memcg_kmem_uncharge_page(struct page *page, > int order) > */ > void mem_cgroup_split_huge_fixup(struct page *head) > {

Re: [PATCH v6 05/19] mm: memcontrol: decouple reference counting from page accounting

2020-06-17 Thread Shakeel Butt
On Mon, Jun 8, 2020 at 4:07 PM Roman Gushchin wrote: > > From: Johannes Weiner > > The reference counting of a memcg is currently coupled directly to how > many 4k pages are charged to it. This doesn't work well with Roman's > new slab controller, which maintains pools of objects and doesn't

[PATCH v6 05/19] mm: memcontrol: decouple reference counting from page accounting

2020-06-08 Thread Roman Gushchin
From: Johannes Weiner The reference counting of a memcg is currently coupled directly to how many 4k pages are charged to it. This doesn't work well with Roman's new slab controller, which maintains pools of objects and doesn't want to keep an extra balance sheet for the pages backing those