Re: [PATCH v6 06/14] irqchip: gicv3-its: platform-msi: refactor its_pmsi_init() to prepare for ACPI

2017-01-04 Thread Hanjun Guo
On 2017/1/4 17:02, Marc Zyngier wrote: On 04/01/17 08:25, Hanjun Guo wrote: On 2017/1/4 15:29, Tomasz Nowicki wrote: On 04.01.2017 08:02, Hanjun Guo wrote: Hi Tomasz, On 2017/1/3 15:41, Tomasz Nowicki wrote: Hi, Can we merge patch 4 & 6 into one patch so that we keep refactoring part as one

Re: [PATCH v6 06/14] irqchip: gicv3-its: platform-msi: refactor its_pmsi_init() to prepare for ACPI

2017-01-04 Thread Marc Zyngier
On 04/01/17 08:25, Hanjun Guo wrote: > On 2017/1/4 15:29, Tomasz Nowicki wrote: >> On 04.01.2017 08:02, Hanjun Guo wrote: >>> Hi Tomasz, >>> >>> On 2017/1/3 15:41, Tomasz Nowicki wrote: Hi, Can we merge patch 4 & 6 into one patch so that we keep refactoring part as one piece ? I

Re: [PATCH v6 06/14] irqchip: gicv3-its: platform-msi: refactor its_pmsi_init() to prepare for ACPI

2017-01-04 Thread Hanjun Guo
On 2017/1/4 15:29, Tomasz Nowicki wrote: On 04.01.2017 08:02, Hanjun Guo wrote: Hi Tomasz, On 2017/1/3 15:41, Tomasz Nowicki wrote: Hi, Can we merge patch 4 & 6 into one patch so that we keep refactoring part as one piece ? I do not see a reason to keep them separate or have patch 5 in betwee

Re: [PATCH v6 06/14] irqchip: gicv3-its: platform-msi: refactor its_pmsi_init() to prepare for ACPI

2017-01-03 Thread Tomasz Nowicki
On 04.01.2017 08:02, Hanjun Guo wrote: Hi Tomasz, On 2017/1/3 15:41, Tomasz Nowicki wrote: Hi, Can we merge patch 4 & 6 into one patch so that we keep refactoring part as one piece ? I do not see a reason to keep them separate or have patch 5 in between. You can refactor what needs to be refac

Re: [PATCH v6 06/14] irqchip: gicv3-its: platform-msi: refactor its_pmsi_init() to prepare for ACPI

2017-01-03 Thread Hanjun Guo
Hi Tomasz, On 2017/1/3 15:41, Tomasz Nowicki wrote: Hi, Can we merge patch 4 & 6 into one patch so that we keep refactoring part as one piece ? I do not see a reason to keep them separate or have patch 5 in between. You can refactor what needs to be refactored, add necessary functions to iort.c

Re: [PATCH v6 06/14] irqchip: gicv3-its: platform-msi: refactor its_pmsi_init() to prepare for ACPI

2017-01-02 Thread Tomasz Nowicki
Hi, Can we merge patch 4 & 6 into one patch so that we keep refactoring part as one piece ? I do not see a reason to keep them separate or have patch 5 in between. You can refactor what needs to be refactored, add necessary functions to iort.c and then support ACPI for irq-gic-v3-its-platform

[PATCH v6 06/14] irqchip: gicv3-its: platform-msi: refactor its_pmsi_init() to prepare for ACPI

2017-01-02 Thread Hanjun Guo
Introduce its_pmsi_init_one() to refactor the code to isolate ACPI&DT common code to prepare for ACPI later. Signed-off-by: Hanjun Guo Tested-by: Sinan Kaya Tested-by: Majun Tested-by: Xinwei Kong Cc: Marc Zyngier Cc: Tomasz Nowicki Cc: Thomas Gleixner --- drivers/irqchip/irq-gic-v3-its-pl