Re: [PATCH v6 07/11] VFS hot tracking: Add a /proc interface to control memory usage

2013-12-11 Thread Zhi Yong Wu
Ping ^ 7 On Wed, Nov 6, 2013 at 9:45 PM, Zhi Yong Wu wrote: > From: Zhi Yong Wu > > Introduce a /proc interface hot-mem-high-thresh and > to cap the memory which is consumed by hot_inode_item > and hot_range_item, and they will be in the unit of > 1M bytes. > > Signed-off-by: Chandra

Re: [PATCH v6 07/11] VFS hot tracking: Add a /proc interface to control memory usage

2013-12-11 Thread Zhi Yong Wu
Ping ^ 7 On Wed, Nov 6, 2013 at 9:45 PM, Zhi Yong Wu zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Introduce a /proc interface hot-mem-high-thresh and to cap the memory which is consumed by hot_inode_item and hot_range_item, and they will be in the unit of 1M

Re: [PATCH v6 07/11] VFS hot tracking: Add a /proc interface to control memory usage

2013-11-12 Thread Zhi Yong Wu
On Wed, Nov 13, 2013 at 5:02 AM, Dave Hansen wrote: > On 11/12/2013 12:38 PM, Zhi Yong Wu wrote: >> On Wed, Nov 13, 2013 at 1:05 AM, Dave Hansen wrote: >>> The on/off knob seems to me to be something better left to a mount >>> option, not a global tunable. >> If it is left to a mount option, the

Re: [PATCH v6 07/11] VFS hot tracking: Add a /proc interface to control memory usage

2013-11-12 Thread Dave Hansen
On 11/12/2013 12:38 PM, Zhi Yong Wu wrote: > On Wed, Nov 13, 2013 at 1:05 AM, Dave Hansen wrote: >> The on/off knob seems to me to be something better left to a mount >> option, not a global tunable. > If it is left to a mount option, the user or admin can't change it > *dynamically*. Really?

Re: [PATCH v6 07/11] VFS hot tracking: Add a /proc interface to control memory usage

2013-11-12 Thread Zhi Yong Wu
On Wed, Nov 13, 2013 at 1:05 AM, Dave Hansen wrote: > On 11/11/2013 02:45 PM, Zhi Yong Wu wrote: >> On Tue, Nov 12, 2013 at 6:15 AM, Dave Hansen wrote: >>> In general, why do you have to control the number of these statically? >> It gives the user or admin one optional chance to control the

Re: [PATCH v6 07/11] VFS hot tracking: Add a /proc interface to control memory usage

2013-11-12 Thread Dave Hansen
On 11/11/2013 02:45 PM, Zhi Yong Wu wrote: > On Tue, Nov 12, 2013 at 6:15 AM, Dave Hansen wrote: >> In general, why do you have to control the number of these statically? > It gives the user or admin one optional chance to control the amount > of memory consumed by VFS hot tracking. And you can

Re: [PATCH v6 07/11] VFS hot tracking: Add a /proc interface to control memory usage

2013-11-12 Thread Dave Hansen
On 11/11/2013 02:45 PM, Zhi Yong Wu wrote: On Tue, Nov 12, 2013 at 6:15 AM, Dave Hansen dave.han...@intel.com wrote: In general, why do you have to control the number of these statically? It gives the user or admin one optional chance to control the amount of memory consumed by VFS hot

Re: [PATCH v6 07/11] VFS hot tracking: Add a /proc interface to control memory usage

2013-11-12 Thread Zhi Yong Wu
On Wed, Nov 13, 2013 at 1:05 AM, Dave Hansen dave.han...@intel.com wrote: On 11/11/2013 02:45 PM, Zhi Yong Wu wrote: On Tue, Nov 12, 2013 at 6:15 AM, Dave Hansen dave.han...@intel.com wrote: In general, why do you have to control the number of these statically? It gives the user or admin one

Re: [PATCH v6 07/11] VFS hot tracking: Add a /proc interface to control memory usage

2013-11-12 Thread Dave Hansen
On 11/12/2013 12:38 PM, Zhi Yong Wu wrote: On Wed, Nov 13, 2013 at 1:05 AM, Dave Hansen dave.han...@intel.com wrote: The on/off knob seems to me to be something better left to a mount option, not a global tunable. If it is left to a mount option, the user or admin can't change it

Re: [PATCH v6 07/11] VFS hot tracking: Add a /proc interface to control memory usage

2013-11-12 Thread Zhi Yong Wu
On Wed, Nov 13, 2013 at 5:02 AM, Dave Hansen dave.han...@intel.com wrote: On 11/12/2013 12:38 PM, Zhi Yong Wu wrote: On Wed, Nov 13, 2013 at 1:05 AM, Dave Hansen dave.han...@intel.com wrote: The on/off knob seems to me to be something better left to a mount option, not a global tunable. If it

Re: [PATCH v6 07/11] VFS hot tracking: Add a /proc interface to control memory usage

2013-11-11 Thread Zhi Yong Wu
On Tue, Nov 12, 2013 at 6:15 AM, Dave Hansen wrote: > On 11/06/2013 05:45 AM, Zhi Yong Wu wrote: >> Introduce a /proc interface hot-mem-high-thresh and >> to cap the memory which is consumed by hot_inode_item >> and hot_range_item, and they will be in the unit of >> 1M bytes. > > You don't seem

Re: [PATCH v6 07/11] VFS hot tracking: Add a /proc interface to control memory usage

2013-11-11 Thread Dave Hansen
On 11/06/2013 05:45 AM, Zhi Yong Wu wrote: > Introduce a /proc interface hot-mem-high-thresh and > to cap the memory which is consumed by hot_inode_item > and hot_range_item, and they will be in the unit of > 1M bytes. You don't seem to have any documentation for this, btw... :( > +

Re: [PATCH v6 07/11] VFS hot tracking: Add a /proc interface to control memory usage

2013-11-11 Thread Dave Hansen
On 11/06/2013 05:45 AM, Zhi Yong Wu wrote: Introduce a /proc interface hot-mem-high-thresh and to cap the memory which is consumed by hot_inode_item and hot_range_item, and they will be in the unit of 1M bytes. You don't seem to have any documentation for this, btw... :( +

Re: [PATCH v6 07/11] VFS hot tracking: Add a /proc interface to control memory usage

2013-11-11 Thread Zhi Yong Wu
On Tue, Nov 12, 2013 at 6:15 AM, Dave Hansen dave.han...@intel.com wrote: On 11/06/2013 05:45 AM, Zhi Yong Wu wrote: Introduce a /proc interface hot-mem-high-thresh and to cap the memory which is consumed by hot_inode_item and hot_range_item, and they will be in the unit of 1M bytes. You

[PATCH v6 07/11] VFS hot tracking: Add a /proc interface to control memory usage

2013-11-06 Thread Zhi Yong Wu
From: Zhi Yong Wu Introduce a /proc interface hot-mem-high-thresh and to cap the memory which is consumed by hot_inode_item and hot_range_item, and they will be in the unit of 1M bytes. Signed-off-by: Chandra Seetharaman Signed-off-by: Zhi Yong Wu --- fs/hot_tracking.c| 29

[PATCH v6 07/11] VFS hot tracking: Add a /proc interface to control memory usage

2013-11-06 Thread Zhi Yong Wu
From: Zhi Yong Wu wu...@linux.vnet.ibm.com Introduce a /proc interface hot-mem-high-thresh and to cap the memory which is consumed by hot_inode_item and hot_range_item, and they will be in the unit of 1M bytes. Signed-off-by: Chandra Seetharaman sekha...@us.ibm.com Signed-off-by: Zhi Yong Wu