Re: [PATCH v6 07/22] Replace the XIP page fault handler with the DAX page fault handler

2014-03-20 Thread Dave Chinner
On Thu, Mar 20, 2014 at 03:38:44PM -0400, Matthew Wilcox wrote: > On Tue, Mar 04, 2014 at 11:56:25AM +1100, Dave Chinner wrote: > > > get_block_t is used by the VFS to ask filesystem to translate logical > > > blocks within a file to sectors on a block device. > > > > > > typedef int

Re: [PATCH v6 07/22] Replace the XIP page fault handler with the DAX page fault handler

2014-03-20 Thread Matthew Wilcox
On Tue, Mar 04, 2014 at 11:56:25AM +1100, Dave Chinner wrote: > > get_block_t is used by the VFS to ask filesystem to translate logical > > blocks within a file to sectors on a block device. > > > > typedef int (get_block_t)(struct inode *inode, sector_t iblock, > > struct

Re: [PATCH v6 07/22] Replace the XIP page fault handler with the DAX page fault handler

2014-03-20 Thread Matthew Wilcox
On Tue, Mar 04, 2014 at 11:56:25AM +1100, Dave Chinner wrote: get_block_t is used by the VFS to ask filesystem to translate logical blocks within a file to sectors on a block device. typedef int (get_block_t)(struct inode *inode, sector_t iblock, struct

Re: [PATCH v6 07/22] Replace the XIP page fault handler with the DAX page fault handler

2014-03-20 Thread Dave Chinner
On Thu, Mar 20, 2014 at 03:38:44PM -0400, Matthew Wilcox wrote: On Tue, Mar 04, 2014 at 11:56:25AM +1100, Dave Chinner wrote: get_block_t is used by the VFS to ask filesystem to translate logical blocks within a file to sectors on a block device. typedef int (get_block_t)(struct

Re: [PATCH v6 07/22] Replace the XIP page fault handler with the DAX page fault handler

2014-03-03 Thread Dave Chinner
On Mon, Mar 03, 2014 at 04:07:35PM -0700, Ross Zwisler wrote: > On Mon, 3 Mar 2014, Dave Chinner wrote: > > On Fri, Feb 28, 2014 at 03:20:31PM -0500, Matthew Wilcox wrote: > > > On Fri, Feb 28, 2014 at 10:49:31AM -0700, Toshi Kani wrote: > > > > The original code, > > > > xip_file_fault(), jumps

Re: [PATCH v6 07/22] Replace the XIP page fault handler with the DAX page fault handler

2014-03-03 Thread Ross Zwisler
On Mon, 3 Mar 2014, Dave Chinner wrote: > On Fri, Feb 28, 2014 at 03:20:31PM -0500, Matthew Wilcox wrote: > > On Fri, Feb 28, 2014 at 10:49:31AM -0700, Toshi Kani wrote: > > > The original code, > > > xip_file_fault(), jumps to found: and calls vm_insert_mixed() when > > > get_xip_mem(,,0,,)

Re: [PATCH v6 07/22] Replace the XIP page fault handler with the DAX page fault handler

2014-03-03 Thread Ross Zwisler
On Mon, 3 Mar 2014, Dave Chinner wrote: On Fri, Feb 28, 2014 at 03:20:31PM -0500, Matthew Wilcox wrote: On Fri, Feb 28, 2014 at 10:49:31AM -0700, Toshi Kani wrote: The original code, xip_file_fault(), jumps to found: and calls vm_insert_mixed() when get_xip_mem(,,0,,) succeeded. If

Re: [PATCH v6 07/22] Replace the XIP page fault handler with the DAX page fault handler

2014-03-03 Thread Dave Chinner
On Mon, Mar 03, 2014 at 04:07:35PM -0700, Ross Zwisler wrote: On Mon, 3 Mar 2014, Dave Chinner wrote: On Fri, Feb 28, 2014 at 03:20:31PM -0500, Matthew Wilcox wrote: On Fri, Feb 28, 2014 at 10:49:31AM -0700, Toshi Kani wrote: The original code, xip_file_fault(), jumps to found: and

Re: [PATCH v6 07/22] Replace the XIP page fault handler with the DAX page fault handler

2014-03-02 Thread Dave Chinner
On Fri, Feb 28, 2014 at 03:20:31PM -0500, Matthew Wilcox wrote: > On Fri, Feb 28, 2014 at 10:49:31AM -0700, Toshi Kani wrote: > > On Tue, 2014-02-25 at 09:18 -0500, Matthew Wilcox wrote: > > > Instead of calling aops->get_xip_mem from the fault handler, the > > > filesystem passes a get_block_t

Re: [PATCH v6 07/22] Replace the XIP page fault handler with the DAX page fault handler

2014-03-02 Thread Dave Chinner
On Fri, Feb 28, 2014 at 03:20:31PM -0500, Matthew Wilcox wrote: On Fri, Feb 28, 2014 at 10:49:31AM -0700, Toshi Kani wrote: On Tue, 2014-02-25 at 09:18 -0500, Matthew Wilcox wrote: Instead of calling aops-get_xip_mem from the fault handler, the filesystem passes a get_block_t that is used

Re: [PATCH v6 07/22] Replace the XIP page fault handler with the DAX page fault handler

2014-02-28 Thread Toshi Kani
On Fri, 2014-02-28 at 15:20 -0500, Matthew Wilcox wrote: > On Fri, Feb 28, 2014 at 10:49:31AM -0700, Toshi Kani wrote: > > On Tue, 2014-02-25 at 09:18 -0500, Matthew Wilcox wrote: : > Glad to see you're looking at it. Let me try to help ... Hi Matt, Thanks for the help. This is really a nice

Re: [PATCH v6 07/22] Replace the XIP page fault handler with the DAX page fault handler

2014-02-28 Thread Matthew Wilcox
On Fri, Feb 28, 2014 at 10:49:31AM -0700, Toshi Kani wrote: > On Tue, 2014-02-25 at 09:18 -0500, Matthew Wilcox wrote: > > Instead of calling aops->get_xip_mem from the fault handler, the > > filesystem passes a get_block_t that is used to find the appropriate > > blocks. > : > > +static int

Re: [PATCH v6 07/22] Replace the XIP page fault handler with the DAX page fault handler

2014-02-28 Thread Toshi Kani
On Tue, 2014-02-25 at 09:18 -0500, Matthew Wilcox wrote: > Instead of calling aops->get_xip_mem from the fault handler, the > filesystem passes a get_block_t that is used to find the appropriate > blocks. : > +static int do_dax_fault(struct vm_area_struct *vma, struct vm_fault *vmf, > +

Re: [PATCH v6 07/22] Replace the XIP page fault handler with the DAX page fault handler

2014-02-28 Thread Toshi Kani
On Tue, 2014-02-25 at 09:18 -0500, Matthew Wilcox wrote: Instead of calling aops-get_xip_mem from the fault handler, the filesystem passes a get_block_t that is used to find the appropriate blocks. : +static int do_dax_fault(struct vm_area_struct *vma, struct vm_fault *vmf, +

Re: [PATCH v6 07/22] Replace the XIP page fault handler with the DAX page fault handler

2014-02-28 Thread Matthew Wilcox
On Fri, Feb 28, 2014 at 10:49:31AM -0700, Toshi Kani wrote: On Tue, 2014-02-25 at 09:18 -0500, Matthew Wilcox wrote: Instead of calling aops-get_xip_mem from the fault handler, the filesystem passes a get_block_t that is used to find the appropriate blocks. : +static int

Re: [PATCH v6 07/22] Replace the XIP page fault handler with the DAX page fault handler

2014-02-28 Thread Toshi Kani
On Fri, 2014-02-28 at 15:20 -0500, Matthew Wilcox wrote: On Fri, Feb 28, 2014 at 10:49:31AM -0700, Toshi Kani wrote: On Tue, 2014-02-25 at 09:18 -0500, Matthew Wilcox wrote: : Glad to see you're looking at it. Let me try to help ... Hi Matt, Thanks for the help. This is really a nice

[PATCH v6 07/22] Replace the XIP page fault handler with the DAX page fault handler

2014-02-25 Thread Matthew Wilcox
Instead of calling aops->get_xip_mem from the fault handler, the filesystem passes a get_block_t that is used to find the appropriate blocks. Signed-off-by: Matthew Wilcox --- fs/dax.c | 167 +++ fs/ext2/file.c | 35 -

[PATCH v6 07/22] Replace the XIP page fault handler with the DAX page fault handler

2014-02-25 Thread Matthew Wilcox
Instead of calling aops-get_xip_mem from the fault handler, the filesystem passes a get_block_t that is used to find the appropriate blocks. Signed-off-by: Matthew Wilcox matthew.r.wil...@intel.com --- fs/dax.c | 167 +++ fs/ext2/file.c | 35