Re: [PATCH v6 09/25] perf hists: Basic support of hierarchical report view

Hi Jiri, On Sun, Feb 21, 2016 at 12:18:45AM +0100, Jiri Olsa wrote: > On Tue, Feb 16, 2016 at 11:08:27PM +0900, Namhyung Kim wrote: > > SNIP > > > + int64_t cmp; > > + > > + while (*p != NULL) { > > + parent = *p; > > + iter = rb_entry(parent, struct hist_entry, rb_node_i

Re: [PATCH v6 09/25] perf hists: Basic support of hierarchical report view

On Tue, Feb 16, 2016 at 11:08:27PM +0900, Namhyung Kim wrote: SNIP > + int64_t cmp; > + > + while (*p != NULL) { > + parent = *p; > + iter = rb_entry(parent, struct hist_entry, rb_node_in); > + > + cmp = fmt->collapse(fmt, iter, he); > + if

[PATCH v6 09/25] perf hists: Basic support of hierarchical report view

In the hierarchical view, entries will be grouped and sorted on the first key, and then second key, and so on. Add he->hroot_{in,out} field to keep lower level entries. Actually this can be shared with callchain sorted_root since the hroots are only used by non-leaf entries and callchain is only u