Re: [PATCH v6 1/2] x86: fix bitops.h warning with a moved cast

2020-05-04 Thread Nick Desaulniers
On Tue, Mar 10, 2020 at 03:17:46PM -0700, Jesse Brandeburg wrote: > Fix many sparse warnings when building with C=1. These are useless > noise from the bitops.h file and getting rid of them helps devs > make more use of the tools and possibly find real bugs. > > When the kernel is compiled with C=

Re: [PATCH v6 1/2] x86: fix bitops.h warning with a moved cast

2020-05-04 Thread Jesse Brandeburg
On Mon, 4 May 2020 12:51:12 -0700 Nick Desaulniers wrote: > Sorry for the very late report. It turns out that if your config > tickles __builtin_constant_p just right, this now produces invalid > assembly: > > $ cat foo.c > long a(long b, long c) { > asm("orb\t%1, %0" : "+q"(c): "r"(b)); >

Re: [PATCH v6 1/2] x86: fix bitops.h warning with a moved cast

2020-05-05 Thread Andy Shevchenko
On Mon, May 04, 2020 at 06:14:43PM -0700, Jesse Brandeburg wrote: > On Mon, 4 May 2020 12:51:12 -0700 > Nick Desaulniers wrote: > > > Sorry for the very late report. It turns out that if your config > > tickles __builtin_constant_p just right, this now produces invalid > > assembly: > > > > $ c

Re: [PATCH v6 1/2] x86: fix bitops.h warning with a moved cast

2020-05-05 Thread Nick Desaulniers
On Tue, May 5, 2020 at 8:14 AM Andy Shevchenko wrote: > > On Mon, May 04, 2020 at 06:14:43PM -0700, Jesse Brandeburg wrote: > > On Mon, 4 May 2020 12:51:12 -0700 > > Nick Desaulniers wrote: > > > > > Sorry for the very late report. It turns out that if your config > > > tickles __builtin_constan

Re: [PATCH v6 1/2] x86: fix bitops.h warning with a moved cast

2020-05-05 Thread Nick Desaulniers
On Tue, May 5, 2020 at 10:29 AM Nick Desaulniers wrote: > > On Tue, May 5, 2020 at 8:14 AM Andy Shevchenko > wrote: > > > > On Mon, May 04, 2020 at 06:14:43PM -0700, Jesse Brandeburg wrote: > > > On Mon, 4 May 2020 12:51:12 -0700 > > > Nick Desaulniers wrote: > > > > > > > Sorry for the very lat