Re: [PATCH v6 1/4] perf,record: Add clockid parameter

2015-03-31 Thread Peter Zijlstra
On Tue, Mar 31, 2015 at 12:19:31AM +0200, Stephane Eranian wrote: > @@ -1044,6 +1051,8 @@ static size_t perf_event_attr__fprintf(struct > perf_event_attr *attr, FILE *fp) > ret += PRINT_ATTR2(exclude_host, exclude_guest); > ret += PRINT_ATTR2N("excl.callchain_kern",

Re: [PATCH v6 1/4] perf,record: Add clockid parameter

2015-03-31 Thread Peter Zijlstra
On Tue, Mar 31, 2015 at 12:19:31AM +0200, Stephane Eranian wrote: You seem to have misplaced the hunk that goes with the fallback_missing_features: label. > @@ -1122,6 +1132,16 @@ static int __perf_evsel__open(struct perf_evsel > *evsel, struct cpu_map *cpus, >

Re: [PATCH v6 1/4] perf,record: Add clockid parameter

2015-03-31 Thread Peter Zijlstra
On Tue, Mar 31, 2015 at 12:19:31AM +0200, Stephane Eranian wrote: You seem to have misplaced the hunk that goes with the fallback_missing_features: label. @@ -1122,6 +1132,16 @@ static int __perf_evsel__open(struct perf_evsel *evsel, struct cpu_map *cpus, goto

Re: [PATCH v6 1/4] perf,record: Add clockid parameter

2015-03-31 Thread Peter Zijlstra
On Tue, Mar 31, 2015 at 12:19:31AM +0200, Stephane Eranian wrote: @@ -1044,6 +1051,8 @@ static size_t perf_event_attr__fprintf(struct perf_event_attr *attr, FILE *fp) ret += PRINT_ATTR2(exclude_host, exclude_guest); ret += PRINT_ATTR2N(excl.callchain_kern,

Re: [PATCH v6 1/4] perf,record: Add clockid parameter

2015-03-30 Thread Stephane Eranian
On Mon, Mar 30, 2015 at 3:24 PM, David Ahern wrote: > On 3/30/15 4:19 PM, Stephane Eranian wrote: >> >> @@ -761,6 +762,12 @@ void perf_evsel__config(struct perf_evsel *evsel, >> struct record_opts *opts) >> attr->disabled = 0; >> attr->enable_on_exec = 0; >>

Re: [PATCH v6 1/4] perf,record: Add clockid parameter

2015-03-30 Thread David Ahern
On 3/30/15 4:19 PM, Stephane Eranian wrote: @@ -761,6 +762,12 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts) attr->disabled = 0; attr->enable_on_exec = 0; } + + if (opts->clockid >= 0) { +

[PATCH v6 1/4] perf,record: Add clockid parameter

2015-03-30 Thread Stephane Eranian
From: Peter Zijlstra Teach perf-record about the new perf_event_attr:{use_+clockid, clockid} fields. Add a simple parameter to set the clock (if any) to be used for the events to be recorded into the dat file. Incorporated improvements suggested by from David Ahern on LKML. Signed-off-by:

Re: [PATCH v6 1/4] perf,record: Add clockid parameter

2015-03-30 Thread David Ahern
On 3/30/15 4:19 PM, Stephane Eranian wrote: @@ -761,6 +762,12 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts) attr-disabled = 0; attr-enable_on_exec = 0; } + + if (opts-clockid = 0) { + attr-use_clockid =

[PATCH v6 1/4] perf,record: Add clockid parameter

2015-03-30 Thread Stephane Eranian
From: Peter Zijlstra pet...@infradead.org Teach perf-record about the new perf_event_attr:{use_+clockid, clockid} fields. Add a simple parameter to set the clock (if any) to be used for the events to be recorded into the dat file. Incorporated improvements suggested by from David Ahern

Re: [PATCH v6 1/4] perf,record: Add clockid parameter

2015-03-30 Thread Stephane Eranian
On Mon, Mar 30, 2015 at 3:24 PM, David Ahern dsah...@gmail.com wrote: On 3/30/15 4:19 PM, Stephane Eranian wrote: @@ -761,6 +762,12 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts) attr-disabled = 0; attr-enable_on_exec = 0;