Re: [PATCH v6 1/5] firmware: add extensible driver data params

2017-04-26 Thread Luis R. Rodriguez
On Thu, Apr 06, 2017 at 10:26:12AM +0300, Luca Coelho wrote: > On Wed, 2017-03-29 at 20:25 -0700, Luis R. Rodriguez wrote: > > Signed-off-by: Luis R. Rodriguez > > --- > > Looks fine with a few nitpicks. > > > > diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c > > inde

Re: [PATCH v6 1/5] firmware: add extensible driver data params

2017-04-06 Thread Luca Coelho
On Wed, 2017-03-29 at 20:25 -0700, Luis R. Rodriguez wrote: > As the firmware API evolves we keep extending functions with more arguments. > Stop this nonsense by proving an extensible data structure which can be used > to represent both user parameters and private internal parameters. > > We intr

[PATCH v6 1/5] firmware: add extensible driver data params

2017-03-29 Thread Luis R. Rodriguez
As the firmware API evolves we keep extending functions with more arguments. Stop this nonsense by proving an extensible data structure which can be used to represent both user parameters and private internal parameters. We introduce 3 data structures: o struct driver_data_req_params - used fo