Re: [PATCH v6 1/5] pinctrl: mediatek: Check gpio pin number and use binary search in mtk_hw_pin_field_lookup()

2019-09-27 Thread Sean Wang
On Thu, Sep 26, 2019 at 10:14 PM Light Hsieh wrote: > > Dear reviewers: > > Patch v6 improves v5 by: > > 1.in mtk_pinconf_get() and mtk_pinconf_set() @pinctrl-paris.c: > * check if pin is in range before using pin as array index of > hw->soc->pins[] > 2.in mtk_pin_field_lookup()

Re: [PATCH v6 1/5] pinctrl: mediatek: Check gpio pin number and use binary search in mtk_hw_pin_field_lookup()

2019-09-26 Thread Light Hsieh
Dear reviewers: Patch v6 improves v5 by: 1.in mtk_pinconf_get() and mtk_pinconf_set() @pinctrl-paris.c: * check if pin is in range before using pin as array index of hw->soc->pins[] 2.in mtk_pin_field_lookup() @pinctrl-mtk-common-v2.c: * declear start, end, check as signed integer

[PATCH v6 1/5] pinctrl: mediatek: Check gpio pin number and use binary search in mtk_hw_pin_field_lookup()

2019-09-26 Thread Light Hsieh
1. Check if gpio pin number is in valid range to prevent from get invalid pointer 'desc' in the following code: desc = (const struct mtk_pin_desc *)>soc->pins[gpio]; 2. Use binary search in mtk_hw_pin_field_lookup() Modify mtk_hw_pin_field_lookup() to use binary search for