Re: [PATCH v6 10/25] perf hists: Resort hist entries with hierarchy

2016-02-21 Thread Namhyung Kim
On Sun, Feb 21, 2016 at 12:19:18AM +0100, Jiri Olsa wrote: > On Tue, Feb 16, 2016 at 11:08:28PM +0900, Namhyung Kim wrote: > > SNIP > > > @@ -1349,6 +1427,17 @@ static void output_resort(struct hists *hists, > > struct ui_progress *prog, > > > > min_callchain_hits = callchain_total *

Re: [PATCH v6 10/25] perf hists: Resort hist entries with hierarchy

2016-02-21 Thread Namhyung Kim
On Sun, Feb 21, 2016 at 12:19:18AM +0100, Jiri Olsa wrote: > On Tue, Feb 16, 2016 at 11:08:28PM +0900, Namhyung Kim wrote: > > SNIP > > > @@ -1349,6 +1427,17 @@ static void output_resort(struct hists *hists, > > struct ui_progress *prog, > > > > min_callchain_hits = callchain_total *

Re: [PATCH v6 10/25] perf hists: Resort hist entries with hierarchy

2016-02-20 Thread Jiri Olsa
On Tue, Feb 16, 2016 at 11:08:28PM +0900, Namhyung Kim wrote: SNIP > @@ -1349,6 +1427,17 @@ static void output_resort(struct hists *hists, struct > ui_progress *prog, > > min_callchain_hits = callchain_total * (callchain_param.min_percent / > 100); > > +

Re: [PATCH v6 10/25] perf hists: Resort hist entries with hierarchy

2016-02-20 Thread Jiri Olsa
On Tue, Feb 16, 2016 at 11:08:28PM +0900, Namhyung Kim wrote: SNIP > @@ -1349,6 +1427,17 @@ static void output_resort(struct hists *hists, struct > ui_progress *prog, > > min_callchain_hits = callchain_total * (callchain_param.min_percent / > 100); > > +

[PATCH v6 10/25] perf hists: Resort hist entries with hierarchy

2016-02-16 Thread Namhyung Kim
For hierarchical output, each entries should be sorted in their rbtree (hroot) properly. Add hists__hierarchy_output_resort() to do the job. Note that those hierarchy entries share the period counts, it'd be important to update the hists->stats only once (for leaves). Acked-by: Pekka Enberg

[PATCH v6 10/25] perf hists: Resort hist entries with hierarchy

2016-02-16 Thread Namhyung Kim
For hierarchical output, each entries should be sorted in their rbtree (hroot) properly. Add hists__hierarchy_output_resort() to do the job. Note that those hierarchy entries share the period counts, it'd be important to update the hists->stats only once (for leaves). Acked-by: Pekka Enberg