Re: [PATCH v6 11/11] media: uvcvideo: use dev_printk() for uvc_trace()

Hi Joe On Wed, Dec 23, 2020 at 12:30 PM Joe Perches wrote: > > Perhaps this on top. > > trace isn't a good name as it's not a trace mechanism, it is a > typical debug mechanism. > > Rename uvc_trace/uvc_trace_cont macros to uvc_dbg/uvc_dbg_cont. > Rename uvc_trace_param to uvc_dbg_param > Rename

Re: [PATCH v6 11/11] media: uvcvideo: use dev_printk() for uvc_trace()

Perhaps this on top. trace isn't a good name as it's not a trace mechanism, it is a typical debug mechanism. Rename uvc_trace/uvc_trace_cont macros to uvc_dbg/uvc_dbg_cont. Rename uvc_trace_param to uvc_dbg_param Rename UVC_TRACE_ defines to UVC_DBG_ Use ## concatenation in uvc_dbg macros to

[PATCH v6 11/11] media: uvcvideo: use dev_printk() for uvc_trace()

Instead of calling prink() inside uvc_trace, use dev_printk(), which adds context to the output. Now that we are at it, regroup the strings so the messages can be easily "grepable". Reviewed-by: Laurent Pinchart Suggested-by: Laurent Pinchart Signed-off-by: Ricardo Ribalda ---