Re: [PATCH v6 12/13] block: Add bio_clone_bioset(), bio_clone_kmalloc()

2012-08-24 Thread Tejun Heo
Hello, On Thu, Aug 23, 2012 at 11:24:18PM -0700, Kent Overstreet wrote: > > I'd prefer simply adding @bioset to bio_clone() so that the caller > > always has to make the choice consciously. We're updating all the > > callers anyway. > > Possibly, but the btrfs code uses bio_clone() and there fs_

Re: [PATCH v6 12/13] block: Add bio_clone_bioset(), bio_clone_kmalloc()

2012-08-23 Thread Kent Overstreet
On Wed, Aug 22, 2012 at 02:07:40PM -0700, Tejun Heo wrote: > On Wed, Aug 22, 2012 at 10:04:09AM -0700, Kent Overstreet wrote: > > Previously, there was bio_clone() but it only allocated from the fs bio > > set; as a result various users were open coding it and using > > __bio_clone(). > > > > This

Re: [PATCH v6 12/13] block: Add bio_clone_bioset(), bio_clone_kmalloc()

2012-08-22 Thread Tejun Heo
On Wed, Aug 22, 2012 at 10:04:09AM -0700, Kent Overstreet wrote: > Previously, there was bio_clone() but it only allocated from the fs bio > set; as a result various users were open coding it and using > __bio_clone(). > > This changes bio_clone() to become bio_clone_bioset(), and then we add > bi

Re: [PATCH v6 12/13] block: Add bio_clone_bioset(), bio_clone_kmalloc()

2012-08-22 Thread Jeff Garzik
On 08/22/2012 01:04 PM, Kent Overstreet wrote: Previously, there was bio_clone() but it only allocated from the fs bio set; as a result various users were open coding it and using __bio_clone(). This changes bio_clone() to become bio_clone_bioset(), and then we add bio_clone() and bio_clone_kmal

[PATCH v6 12/13] block: Add bio_clone_bioset(), bio_clone_kmalloc()

2012-08-22 Thread Kent Overstreet
Previously, there was bio_clone() but it only allocated from the fs bio set; as a result various users were open coding it and using __bio_clone(). This changes bio_clone() to become bio_clone_bioset(), and then we add bio_clone() and bio_clone_kmalloc() as wrappers around it, making use of the fu