Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-02-02 Thread Masahiro Yamada
On Sat, Jan 30, 2021 at 7:42 AM Sedat Dilek wrote: > > On Fri, Jan 29, 2021 at 11:31 PM Nick Desaulniers > wrote: > > > > On Fri, Jan 29, 2021 at 2:23 PM Sedat Dilek wrote: > > > > > > On Fri, Jan 29, 2021 at 11:21 PM Nick Desaulniers > > > wrote: > > > > > > > > On Fri, Jan 29, 2021 at 2:11

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Nick Desaulniers
On Fri, Jan 29, 2021 at 3:25 PM Nick Desaulniers wrote: > > On Fri, Jan 29, 2021 at 2:10 PM Jakub Jelinek wrote: > > > > On Fri, Jan 29, 2021 at 02:05:59PM -0800, Nick Desaulniers wrote: > > > Ah, I see. Then I should update the script I add > > > (scripts/test_dwarf5_support.sh) to feature

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Nick Desaulniers
On Fri, Jan 29, 2021 at 2:10 PM Jakub Jelinek wrote: > > On Fri, Jan 29, 2021 at 02:05:59PM -0800, Nick Desaulniers wrote: > > Ah, I see. Then I should update the script I add > > (scripts/test_dwarf5_support.sh) to feature detect that bug, since > > it's the latest of the bunch. Also, should

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Fangrui Song
On 2021-01-29, Nick Desaulniers wrote: DWARF v5 is the latest standard of the DWARF debug info format. Feature detection of DWARF5 is onerous, especially given that we've removed $(AS), so we must query $(CC) for DWARF5 assembler directive support. The DWARF version of a binary can be

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Sedat Dilek
On Fri, Jan 29, 2021 at 11:31 PM Nick Desaulniers wrote: > > On Fri, Jan 29, 2021 at 2:23 PM Sedat Dilek wrote: > > > > On Fri, Jan 29, 2021 at 11:21 PM Nick Desaulniers > > wrote: > > > > > > On Fri, Jan 29, 2021 at 2:11 PM Sedat Dilek wrote: > > > > > > > > On Fri, Jan 29, 2021 at 11:09 PM

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Nick Desaulniers
On Fri, Jan 29, 2021 at 2:23 PM Sedat Dilek wrote: > > On Fri, Jan 29, 2021 at 11:21 PM Nick Desaulniers > wrote: > > > > On Fri, Jan 29, 2021 at 2:11 PM Sedat Dilek wrote: > > > > > > On Fri, Jan 29, 2021 at 11:09 PM Nick Desaulniers > > > wrote: > > > > > > > > On Fri, Jan 29, 2021 at 1:20

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Nick Desaulniers
On Fri, Jan 29, 2021 at 1:11 PM Jakub Jelinek wrote: > > On Fri, Jan 29, 2021 at 01:05:56PM -0800, Nick Desaulniers wrote: > > > Wasn't that fixed in GAS? > > > https://sourceware.org/bugzilla/show_bug.cgi?id=27195 > > > > $ make LLVM=1 -j72 defconfig > > $ ./scripts/config -e DEBUG_INFO -e

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Sedat Dilek
On Fri, Jan 29, 2021 at 11:21 PM Nick Desaulniers wrote: > > On Fri, Jan 29, 2021 at 2:11 PM Sedat Dilek wrote: > > > > On Fri, Jan 29, 2021 at 11:09 PM Nick Desaulniers > > wrote: > > > > > > On Fri, Jan 29, 2021 at 1:20 PM Sedat Dilek wrote: > > > > > > > > On Fri, Jan 29, 2021 at 10:13 PM

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Nick Desaulniers
On Fri, Jan 29, 2021 at 2:11 PM Sedat Dilek wrote: > > On Fri, Jan 29, 2021 at 11:09 PM Nick Desaulniers > wrote: > > > > On Fri, Jan 29, 2021 at 1:20 PM Sedat Dilek wrote: > > > > > > On Fri, Jan 29, 2021 at 10:13 PM Sedat Dilek > > > wrote: > > > > > > > > On Fri, Jan 29, 2021 at 10:09 PM

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Sedat Dilek
On Fri, Jan 29, 2021 at 11:09 PM Nick Desaulniers wrote: > > On Fri, Jan 29, 2021 at 1:20 PM Sedat Dilek wrote: > > > > On Fri, Jan 29, 2021 at 10:13 PM Sedat Dilek wrote: > > > > > > On Fri, Jan 29, 2021 at 10:09 PM Nick Desaulniers > > > wrote: > > > > > > > > On Fri, Jan 29, 2021 at 12:55

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Jakub Jelinek
On Fri, Jan 29, 2021 at 02:05:59PM -0800, Nick Desaulniers wrote: > Ah, I see. Then I should update the script I add > (scripts/test_dwarf5_support.sh) to feature detect that bug, since > it's the latest of the bunch. Also, should update my comment to note > that this requires binutils greater

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Nick Desaulniers
On Fri, Jan 29, 2021 at 1:20 PM Sedat Dilek wrote: > > On Fri, Jan 29, 2021 at 10:13 PM Sedat Dilek wrote: > > > > On Fri, Jan 29, 2021 at 10:09 PM Nick Desaulniers > > wrote: > > > > > > On Fri, Jan 29, 2021 at 12:55 PM Sedat Dilek > > > wrote: > > > > > > > > On Fri, Jan 29, 2021 at 9:48 PM

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Nick Desaulniers
On Fri, Jan 29, 2021 at 1:52 PM Fangrui Song wrote: > > On 2021-01-29, Nick Desaulniers wrote: > >diff --git a/include/asm-generic/vmlinux.lds.h > >b/include/asm-generic/vmlinux.lds.h > >index 34b7e0d2346c..f8d5455cd87f 100644 > >--- a/include/asm-generic/vmlinux.lds.h > >+++

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Nick Desaulniers
On Fri, Jan 29, 2021 at 1:11 PM Jakub Jelinek wrote: > > On Fri, Jan 29, 2021 at 01:05:56PM -0800, Nick Desaulniers wrote: > > > Wasn't that fixed in GAS? > > > https://sourceware.org/bugzilla/show_bug.cgi?id=27195 > > > > $ make LLVM=1 -j72 defconfig > > $ ./scripts/config -e DEBUG_INFO -e

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Fangrui Song
On 2021-01-29, Nick Desaulniers wrote: DWARF v5 is the latest standard of the DWARF debug info format. Feature detection of DWARF5 is onerous, especially given that we've removed $(AS), so we must query $(CC) for DWARF5 assembler directive support. The DWARF version of a binary can be

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Sedat Dilek
On Fri, Jan 29, 2021 at 10:13 PM Sedat Dilek wrote: > > On Fri, Jan 29, 2021 at 10:09 PM Nick Desaulniers > wrote: > > > > On Fri, Jan 29, 2021 at 12:55 PM Sedat Dilek wrote: > > > > > > On Fri, Jan 29, 2021 at 9:48 PM Nick Desaulniers > > > wrote: > > > > > > > > On Fri, Jan 29, 2021 at 12:41

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Sedat Dilek
On Fri, Jan 29, 2021 at 10:09 PM Nick Desaulniers wrote: > > On Fri, Jan 29, 2021 at 12:55 PM Sedat Dilek wrote: > > > > On Fri, Jan 29, 2021 at 9:48 PM Nick Desaulniers > > wrote: > > > > > > On Fri, Jan 29, 2021 at 12:41 PM Sedat Dilek > > > wrote: > > > > > > > > On Fri, Jan 29, 2021 at

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Jakub Jelinek
On Fri, Jan 29, 2021 at 01:05:56PM -0800, Nick Desaulniers wrote: > > Wasn't that fixed in GAS? > > https://sourceware.org/bugzilla/show_bug.cgi?id=27195 > > $ make LLVM=1 -j72 defconfig > $ ./scripts/config -e DEBUG_INFO -e DEBUG_INFO_DWARF5 > $ make LLVM=1 -j72 > ... > /tmp/init-d50d89.s:

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Nick Desaulniers
On Fri, Jan 29, 2021 at 12:55 PM Sedat Dilek wrote: > > On Fri, Jan 29, 2021 at 9:48 PM Nick Desaulniers > wrote: > > > > On Fri, Jan 29, 2021 at 12:41 PM Sedat Dilek wrote: > > > > > > On Fri, Jan 29, 2021 at 8:43 PM Nick Desaulniers > > > wrote: > > > > > > > > diff --git a/Makefile

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Nick Desaulniers
On Fri, Jan 29, 2021 at 12:57 PM Jakub Jelinek wrote: > > On Fri, Jan 29, 2021 at 12:48:11PM -0800, Nick Desaulniers wrote: > > > Should this be...? > > > > > > KBUILD_AFLAGS += -Wa,-gdwarf-5 > > > > No; under the set of conditions Clang is compiling .c to .S with DWARF > > v5 assembler

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Jakub Jelinek
On Fri, Jan 29, 2021 at 12:48:11PM -0800, Nick Desaulniers wrote: > > Should this be...? > > > > KBUILD_AFLAGS += -Wa,-gdwarf-5 > > No; under the set of conditions Clang is compiling .c to .S with DWARF > v5 assembler directives. GAS will choke unless told -gdwarf-5 via > -Wa,-gdwarf-5 for .c

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Sedat Dilek
On Fri, Jan 29, 2021 at 9:48 PM Nick Desaulniers wrote: > > On Fri, Jan 29, 2021 at 12:41 PM Sedat Dilek wrote: > > > > On Fri, Jan 29, 2021 at 8:43 PM Nick Desaulniers > > wrote: > > > > > > diff --git a/Makefile b/Makefile > > > index 20141cd9319e..bed8b3b180b8 100644 > > > --- a/Makefile > >

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Nick Desaulniers
On Fri, Jan 29, 2021 at 12:41 PM Sedat Dilek wrote: > > On Fri, Jan 29, 2021 at 8:43 PM Nick Desaulniers > wrote: > > > > diff --git a/Makefile b/Makefile > > index 20141cd9319e..bed8b3b180b8 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -832,8 +832,20 @@ endif > > > >

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Sedat Dilek
On Fri, Jan 29, 2021 at 8:43 PM Nick Desaulniers wrote: > > DWARF v5 is the latest standard of the DWARF debug info format. > > Feature detection of DWARF5 is onerous, especially given that we've > removed $(AS), so we must query $(CC) for DWARF5 assembler directive > support. > > The DWARF

[PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Nick Desaulniers
DWARF v5 is the latest standard of the DWARF debug info format. Feature detection of DWARF5 is onerous, especially given that we've removed $(AS), so we must query $(CC) for DWARF5 assembler directive support. The DWARF version of a binary can be validated with: $ llvm-dwarfdump vmlinux | head