Re: [PATCH v6 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver

2018-12-05 Thread Hanjie Lin
On 2018/12/4 20:00, Lorenzo Pieralisi wrote: > On Tue, Dec 04, 2018 at 06:40:55PM +0800, Hanjie Lin wrote: >> >> >> On 2018/12/4 6:57, Bjorn Helgaas wrote: >>> On Mon, Dec 03, 2018 at 04:41:50PM +, Lorenzo Pieralisi wrote: On Thu, Nov 22, 2018 at 04:53:54PM +0800, Hanjie Lin wrote:

Re: [PATCH v6 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver

2018-12-05 Thread Hanjie Lin
On 2018/12/4 20:00, Lorenzo Pieralisi wrote: > On Tue, Dec 04, 2018 at 06:40:55PM +0800, Hanjie Lin wrote: >> >> >> On 2018/12/4 6:57, Bjorn Helgaas wrote: >>> On Mon, Dec 03, 2018 at 04:41:50PM +, Lorenzo Pieralisi wrote: On Thu, Nov 22, 2018 at 04:53:54PM +0800, Hanjie Lin wrote:

Re: [PATCH v6 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver

2018-12-04 Thread Lorenzo Pieralisi
On Tue, Dec 04, 2018 at 06:40:55PM +0800, Hanjie Lin wrote: > > > On 2018/12/4 6:57, Bjorn Helgaas wrote: > > On Mon, Dec 03, 2018 at 04:41:50PM +, Lorenzo Pieralisi wrote: > >> On Thu, Nov 22, 2018 at 04:53:54PM +0800, Hanjie Lin wrote: > >> > >> [...] > >> > >>> +static int

Re: [PATCH v6 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver

2018-12-04 Thread Lorenzo Pieralisi
On Tue, Dec 04, 2018 at 06:40:55PM +0800, Hanjie Lin wrote: > > > On 2018/12/4 6:57, Bjorn Helgaas wrote: > > On Mon, Dec 03, 2018 at 04:41:50PM +, Lorenzo Pieralisi wrote: > >> On Thu, Nov 22, 2018 at 04:53:54PM +0800, Hanjie Lin wrote: > >> > >> [...] > >> > >>> +static int

Re: [PATCH v6 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver

2018-12-04 Thread Hanjie Lin
On 2018/12/4 6:57, Bjorn Helgaas wrote: > On Mon, Dec 03, 2018 at 04:41:50PM +, Lorenzo Pieralisi wrote: >> On Thu, Nov 22, 2018 at 04:53:54PM +0800, Hanjie Lin wrote: >> >> [...] >> >>> +static int meson_pcie_rd_own_conf(struct pcie_port *pp, int where, int >>> size, >>> +

Re: [PATCH v6 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver

2018-12-04 Thread Hanjie Lin
On 2018/12/4 6:57, Bjorn Helgaas wrote: > On Mon, Dec 03, 2018 at 04:41:50PM +, Lorenzo Pieralisi wrote: >> On Thu, Nov 22, 2018 at 04:53:54PM +0800, Hanjie Lin wrote: >> >> [...] >> >>> +static int meson_pcie_rd_own_conf(struct pcie_port *pp, int where, int >>> size, >>> +

Re: [PATCH v6 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver

2018-12-03 Thread Bjorn Helgaas
On Mon, Dec 03, 2018 at 04:41:50PM +, Lorenzo Pieralisi wrote: > On Thu, Nov 22, 2018 at 04:53:54PM +0800, Hanjie Lin wrote: > > [...] > > > +static int meson_pcie_rd_own_conf(struct pcie_port *pp, int where, int > > size, > > + u32 *val) > > +{ > > + struct

Re: [PATCH v6 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver

2018-12-03 Thread Bjorn Helgaas
On Mon, Dec 03, 2018 at 04:41:50PM +, Lorenzo Pieralisi wrote: > On Thu, Nov 22, 2018 at 04:53:54PM +0800, Hanjie Lin wrote: > > [...] > > > +static int meson_pcie_rd_own_conf(struct pcie_port *pp, int where, int > > size, > > + u32 *val) > > +{ > > + struct

Re: [PATCH v6 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver

2018-12-03 Thread Lorenzo Pieralisi
On Thu, Nov 22, 2018 at 04:53:54PM +0800, Hanjie Lin wrote: [...] > +static int meson_pcie_rd_own_conf(struct pcie_port *pp, int where, int size, > + u32 *val) > +{ > + struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > + > + /* > + * there is a bug of

Re: [PATCH v6 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver

2018-12-03 Thread Lorenzo Pieralisi
On Thu, Nov 22, 2018 at 04:53:54PM +0800, Hanjie Lin wrote: [...] > +static int meson_pcie_rd_own_conf(struct pcie_port *pp, int where, int size, > + u32 *val) > +{ > + struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > + > + /* > + * there is a bug of

Re: [PATCH v6 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver

2018-11-29 Thread Dan Carpenter
On Thu, Nov 29, 2018 at 08:08:57PM +0800, Hanjie Lin wrote: > Yes, it's really a silly mistake. No one gets annoyed about typos. We're all human and we make mistakes. (This was going to an uplifting email, but then I had to mention that what does make people annoyed is OS abstraction layers.

Re: [PATCH v6 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver

2018-11-29 Thread Dan Carpenter
On Thu, Nov 29, 2018 at 08:08:57PM +0800, Hanjie Lin wrote: > Yes, it's really a silly mistake. No one gets annoyed about typos. We're all human and we make mistakes. (This was going to an uplifting email, but then I had to mention that what does make people annoyed is OS abstraction layers.

Re: [PATCH v6 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver

2018-11-29 Thread Hanjie Lin
On 2018/11/29 17:03, Dan Carpenter wrote: > Hi Yue, > > url: > https://github.com/0day-ci/linux/commits/Hanjie-Lin/dt-bindings-PCI-meson-add-DT-bindings-for-Amlogic-Meson-PCIe-controller/20181122-225955 > base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next > >

Re: [PATCH v6 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver

2018-11-29 Thread Hanjie Lin
On 2018/11/29 17:03, Dan Carpenter wrote: > Hi Yue, > > url: > https://github.com/0day-ci/linux/commits/Hanjie-Lin/dt-bindings-PCI-meson-add-DT-bindings-for-Amlogic-Meson-PCIe-controller/20181122-225955 > base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next > >

Re: [PATCH v6 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver

2018-11-29 Thread Dan Carpenter
Hi Yue, url: https://github.com/0day-ci/linux/commits/Hanjie-Lin/dt-bindings-PCI-meson-add-DT-bindings-for-Amlogic-Meson-PCIe-controller/20181122-225955 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next smatch warnings: drivers/pci/controller/dwc/pci-meson.c:171

Re: [PATCH v6 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver

2018-11-29 Thread Dan Carpenter
Hi Yue, url: https://github.com/0day-ci/linux/commits/Hanjie-Lin/dt-bindings-PCI-meson-add-DT-bindings-for-Amlogic-Meson-PCIe-controller/20181122-225955 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next smatch warnings: drivers/pci/controller/dwc/pci-meson.c:171

[PATCH v6 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver

2018-11-22 Thread Hanjie Lin
From: Yue Wang The Amlogic Meson PCIe host controller is based on the Synopsys DesignWare PCI core. This patch adds the driver support for Meson PCIe controller. Signed-off-by: Yue Wang Signed-off-by: Hanjie Lin --- MAINTAINERS| 7 +

[PATCH v6 2/2] PCI: amlogic: Add the Amlogic Meson PCIe controller driver

2018-11-22 Thread Hanjie Lin
From: Yue Wang The Amlogic Meson PCIe host controller is based on the Synopsys DesignWare PCI core. This patch adds the driver support for Meson PCIe controller. Signed-off-by: Yue Wang Signed-off-by: Hanjie Lin --- MAINTAINERS| 7 +