Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-26 Thread Daniel Lezcano
On 08/24/2016 07:40 PM, Rich Felker wrote: [ ... ] >>> +config CLKSRC_JCORE_PIT >>> + bool "J-Core PIT timer driver" >>> + depends on OF && (SUPERH || COMPILE_TEST) >> >> Even if this is correct, for the sake of consistency, it is preferable >> to change it to: >> >> bool "J-Core PIT

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-26 Thread Daniel Lezcano
On 08/24/2016 07:40 PM, Rich Felker wrote: [ ... ] >>> +config CLKSRC_JCORE_PIT >>> + bool "J-Core PIT timer driver" >>> + depends on OF && (SUPERH || COMPILE_TEST) >> >> Even if this is correct, for the sake of consistency, it is preferable >> to change it to: >> >> bool "J-Core PIT

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-25 Thread Rich Felker
On Thu, Aug 25, 2016 at 07:21:13PM +0100, Mark Rutland wrote: > On Thu, Aug 25, 2016 at 01:51:35PM -0400, Rich Felker wrote: > > On Thu, Aug 25, 2016 at 05:38:06PM +0100, Mark Rutland wrote: > > > On Thu, Aug 25, 2016 at 10:56:50AM -0400, Rich Felker wrote: > > > > On Thu, Aug 25, 2016 at

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-25 Thread Rich Felker
On Thu, Aug 25, 2016 at 07:21:13PM +0100, Mark Rutland wrote: > On Thu, Aug 25, 2016 at 01:51:35PM -0400, Rich Felker wrote: > > On Thu, Aug 25, 2016 at 05:38:06PM +0100, Mark Rutland wrote: > > > On Thu, Aug 25, 2016 at 10:56:50AM -0400, Rich Felker wrote: > > > > On Thu, Aug 25, 2016 at

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-25 Thread Rich Felker
On Thu, Aug 25, 2016 at 05:38:06PM +0100, Mark Rutland wrote: > On Thu, Aug 25, 2016 at 10:56:50AM -0400, Rich Felker wrote: > > On Thu, Aug 25, 2016 at 10:07:08AM +0200, Thomas Gleixner wrote: > > > On Wed, 24 Aug 2016, Rich Felker wrote: > > As for this topic, what happened is that, after the

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-25 Thread Rich Felker
On Thu, Aug 25, 2016 at 05:38:06PM +0100, Mark Rutland wrote: > On Thu, Aug 25, 2016 at 10:56:50AM -0400, Rich Felker wrote: > > On Thu, Aug 25, 2016 at 10:07:08AM +0200, Thomas Gleixner wrote: > > > On Wed, 24 Aug 2016, Rich Felker wrote: > > As for this topic, what happened is that, after the

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-25 Thread Mark Rutland
On Thu, Aug 25, 2016 at 01:51:35PM -0400, Rich Felker wrote: > On Thu, Aug 25, 2016 at 05:38:06PM +0100, Mark Rutland wrote: > > On Thu, Aug 25, 2016 at 10:56:50AM -0400, Rich Felker wrote: > > > On Thu, Aug 25, 2016 at 10:07:08AM +0200, Thomas Gleixner wrote: > > > Nominally it uses the same

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-25 Thread Mark Rutland
On Thu, Aug 25, 2016 at 01:51:35PM -0400, Rich Felker wrote: > On Thu, Aug 25, 2016 at 05:38:06PM +0100, Mark Rutland wrote: > > On Thu, Aug 25, 2016 at 10:56:50AM -0400, Rich Felker wrote: > > > On Thu, Aug 25, 2016 at 10:07:08AM +0200, Thomas Gleixner wrote: > > > Nominally it uses the same

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-25 Thread Rich Felker
On Thu, Aug 25, 2016 at 05:41:29PM +0200, Thomas Gleixner wrote: > On Thu, 25 Aug 2016, Rich Felker wrote: > > assumption that is was just a bug. Now that Mark Rutland has explained > > it well (and with your additional explanation below in your email), I > > see what the motivation was, but I

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-25 Thread Rich Felker
On Thu, Aug 25, 2016 at 05:41:29PM +0200, Thomas Gleixner wrote: > On Thu, 25 Aug 2016, Rich Felker wrote: > > assumption that is was just a bug. Now that Mark Rutland has explained > > it well (and with your additional explanation below in your email), I > > see what the motivation was, but I

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-25 Thread Mark Rutland
On Thu, Aug 25, 2016 at 10:56:50AM -0400, Rich Felker wrote: > On Thu, Aug 25, 2016 at 10:07:08AM +0200, Thomas Gleixner wrote: > > On Wed, 24 Aug 2016, Rich Felker wrote: > As for this topic, what happened is that, after the first and second > time of expressing confusion about how the

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-25 Thread Mark Rutland
On Thu, Aug 25, 2016 at 10:56:50AM -0400, Rich Felker wrote: > On Thu, Aug 25, 2016 at 10:07:08AM +0200, Thomas Gleixner wrote: > > On Wed, 24 Aug 2016, Rich Felker wrote: > As for this topic, what happened is that, after the first and second > time of expressing confusion about how the

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-25 Thread Thomas Gleixner
On Thu, 25 Aug 2016, Rich Felker wrote: > assumption that is was just a bug. Now that Mark Rutland has explained > it well (and with your additional explanation below in your email), I > see what the motivation was, but I still think it could be done in a > less-confusing and more-consistent way

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-25 Thread Thomas Gleixner
On Thu, 25 Aug 2016, Rich Felker wrote: > assumption that is was just a bug. Now that Mark Rutland has explained > it well (and with your additional explanation below in your email), I > see what the motivation was, but I still think it could be done in a > less-confusing and more-consistent way

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-25 Thread Rich Felker
On Thu, Aug 25, 2016 at 10:07:08AM +0200, Thomas Gleixner wrote: > Rich, > > On Wed, 24 Aug 2016, Rich Felker wrote: > > I don't think that's a correct characterization. Rather the percpu > > infrastructure just means something completely different from what you > > would expect it to mean. It

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-25 Thread Rich Felker
On Thu, Aug 25, 2016 at 10:07:08AM +0200, Thomas Gleixner wrote: > Rich, > > On Wed, 24 Aug 2016, Rich Felker wrote: > > I don't think that's a correct characterization. Rather the percpu > > infrastructure just means something completely different from what you > > would expect it to mean. It

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-25 Thread Arnd Bergmann
On Wednesday, August 24, 2016 11:57:08 PM CEST Arnd Bergmann wrote: > > I'm not familiar with those classifications, but from what I can tell, > > BE32 describes it correctly. I'll see if I can get someone to verify > > this. Is there a reason it's not widely used anymore? Perhaps > > something

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-25 Thread Arnd Bergmann
On Wednesday, August 24, 2016 11:57:08 PM CEST Arnd Bergmann wrote: > > I'm not familiar with those classifications, but from what I can tell, > > BE32 describes it correctly. I'll see if I can get someone to verify > > this. Is there a reason it's not widely used anymore? Perhaps > > something

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-25 Thread Thomas Gleixner
Rich, On Wed, 24 Aug 2016, Rich Felker wrote: > I don't think that's a correct characterization. Rather the percpu > infrastructure just means something completely different from what you > would expect it to mean. It has nothing to do with the hardware but > rather with kernel-internal choice of

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-25 Thread Thomas Gleixner
Rich, On Wed, 24 Aug 2016, Rich Felker wrote: > I don't think that's a correct characterization. Rather the percpu > infrastructure just means something completely different from what you > would expect it to mean. It has nothing to do with the hardware but > rather with kernel-internal choice of

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-24 Thread Mark Rutland
On Wed, Aug 24, 2016 at 05:44:44PM -0400, Rich Felker wrote: > On Wed, Aug 24, 2016 at 10:22:13PM +0100, Mark Rutland wrote: > > On Wed, Aug 24, 2016 at 04:52:26PM -0400, Rich Felker wrote: > > > On Wed, Aug 24, 2016 at 10:01:08PM +0200, Arnd Bergmann wrote: > > > > On Wednesday, August 24, 2016

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-24 Thread Mark Rutland
On Wed, Aug 24, 2016 at 05:44:44PM -0400, Rich Felker wrote: > On Wed, Aug 24, 2016 at 10:22:13PM +0100, Mark Rutland wrote: > > On Wed, Aug 24, 2016 at 04:52:26PM -0400, Rich Felker wrote: > > > On Wed, Aug 24, 2016 at 10:01:08PM +0200, Arnd Bergmann wrote: > > > > On Wednesday, August 24, 2016

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-24 Thread Mark Rutland
Hi, On Wed, Aug 24, 2016 at 03:20:09PM -0400, Rich Felker wrote: > On Wed, Aug 24, 2016 at 08:01:52PM +0100, Marc Zyngier wrote: > > On Wed, 24 Aug 2016 13:40:01 -0400 > > Rich Felker wrote: > > > > [...] > > > > > > IIUC, there is a problem with the interrupt controller where

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-24 Thread Mark Rutland
Hi, On Wed, Aug 24, 2016 at 03:20:09PM -0400, Rich Felker wrote: > On Wed, Aug 24, 2016 at 08:01:52PM +0100, Marc Zyngier wrote: > > On Wed, 24 Aug 2016 13:40:01 -0400 > > Rich Felker wrote: > > > > [...] > > > > > > IIUC, there is a problem with the interrupt controller where > > the per irq

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-24 Thread Arnd Bergmann
On Wednesday, August 24, 2016 5:44:44 PM CEST Rich Felker wrote: > On Wed, Aug 24, 2016 at 10:22:13PM +0100, Mark Rutland wrote: > > On Wed, Aug 24, 2016 at 04:52:26PM -0400, Rich Felker wrote: > > As Arnd and others mentioned, the vastly common case is that the endianness > > of > > CPUs and

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-24 Thread Arnd Bergmann
On Wednesday, August 24, 2016 5:44:44 PM CEST Rich Felker wrote: > On Wed, Aug 24, 2016 at 10:22:13PM +0100, Mark Rutland wrote: > > On Wed, Aug 24, 2016 at 04:52:26PM -0400, Rich Felker wrote: > > As Arnd and others mentioned, the vastly common case is that the endianness > > of > > CPUs and

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-24 Thread Rich Felker
On Wed, Aug 24, 2016 at 10:22:13PM +0100, Mark Rutland wrote: > On Wed, Aug 24, 2016 at 04:52:26PM -0400, Rich Felker wrote: > > On Wed, Aug 24, 2016 at 10:01:08PM +0200, Arnd Bergmann wrote: > > > On Wednesday, August 24, 2016 1:40:01 PM CEST Rich Felker wrote: > > > > I actually tried multiple

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-24 Thread Rich Felker
On Wed, Aug 24, 2016 at 10:22:13PM +0100, Mark Rutland wrote: > On Wed, Aug 24, 2016 at 04:52:26PM -0400, Rich Felker wrote: > > On Wed, Aug 24, 2016 at 10:01:08PM +0200, Arnd Bergmann wrote: > > > On Wednesday, August 24, 2016 1:40:01 PM CEST Rich Felker wrote: > > > > I actually tried multiple

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-24 Thread Mark Rutland
On Wed, Aug 24, 2016 at 04:52:26PM -0400, Rich Felker wrote: > On Wed, Aug 24, 2016 at 10:01:08PM +0200, Arnd Bergmann wrote: > > On Wednesday, August 24, 2016 1:40:01 PM CEST Rich Felker wrote: > > > I actually tried multiple times to find good resources on policy for > > > which form to prefer,

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-24 Thread Mark Rutland
On Wed, Aug 24, 2016 at 04:52:26PM -0400, Rich Felker wrote: > On Wed, Aug 24, 2016 at 10:01:08PM +0200, Arnd Bergmann wrote: > > On Wednesday, August 24, 2016 1:40:01 PM CEST Rich Felker wrote: > > > I actually tried multiple times to find good resources on policy for > > > which form to prefer,

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-24 Thread Rich Felker
On Wed, Aug 24, 2016 at 10:01:08PM +0200, Arnd Bergmann wrote: > On Wednesday, August 24, 2016 1:40:01 PM CEST Rich Felker wrote: > > On Wed, Aug 24, 2016 at 06:42:05PM +0200, Daniel Lezcano wrote: > > > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > > > > index

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-24 Thread Rich Felker
On Wed, Aug 24, 2016 at 10:01:08PM +0200, Arnd Bergmann wrote: > On Wednesday, August 24, 2016 1:40:01 PM CEST Rich Felker wrote: > > On Wed, Aug 24, 2016 at 06:42:05PM +0200, Daniel Lezcano wrote: > > > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > > > > index

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-24 Thread Arnd Bergmann
On Wednesday, August 24, 2016 1:40:01 PM CEST Rich Felker wrote: > On Wed, Aug 24, 2016 at 06:42:05PM +0200, Daniel Lezcano wrote: > > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > > > index 5677886..3210ca5 100644 > > > --- a/drivers/clocksource/Kconfig > > > +++

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-24 Thread Arnd Bergmann
On Wednesday, August 24, 2016 1:40:01 PM CEST Rich Felker wrote: > On Wed, Aug 24, 2016 at 06:42:05PM +0200, Daniel Lezcano wrote: > > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > > > index 5677886..3210ca5 100644 > > > --- a/drivers/clocksource/Kconfig > > > +++

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-24 Thread Rich Felker
On Wed, Aug 24, 2016 at 08:01:52PM +0100, Marc Zyngier wrote: > On Wed, 24 Aug 2016 13:40:01 -0400 > Rich Felker wrote: > > [...] > > > > IIUC, there is a problem with the interrupt controller where > the per irq > > > line are not working correctly. Is that correct ? > > >

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-24 Thread Rich Felker
On Wed, Aug 24, 2016 at 08:01:52PM +0100, Marc Zyngier wrote: > On Wed, 24 Aug 2016 13:40:01 -0400 > Rich Felker wrote: > > [...] > > > > IIUC, there is a problem with the interrupt controller where > the per irq > > > line are not working correctly. Is that correct ? > > > > I don't think

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-24 Thread Marc Zyngier
On Wed, 24 Aug 2016 13:40:01 -0400 Rich Felker wrote: [...] > > IIUC, there is a problem with the interrupt controller where the per irq > > line are not working correctly. Is that correct ? > > I don't think that's a correct characterization. Rather the percpu >

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-24 Thread Marc Zyngier
On Wed, 24 Aug 2016 13:40:01 -0400 Rich Felker wrote: [...] > > IIUC, there is a problem with the interrupt controller where the per irq > > line are not working correctly. Is that correct ? > > I don't think that's a correct characterization. Rather the percpu > infrastructure just means

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-24 Thread Rich Felker
On Wed, Aug 24, 2016 at 06:42:05PM +0200, Daniel Lezcano wrote: > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > > index 5677886..3210ca5 100644 > > --- a/drivers/clocksource/Kconfig > > +++ b/drivers/clocksource/Kconfig > > @@ -407,6 +407,15 @@ config

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-24 Thread Rich Felker
On Wed, Aug 24, 2016 at 06:42:05PM +0200, Daniel Lezcano wrote: > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > > index 5677886..3210ca5 100644 > > --- a/drivers/clocksource/Kconfig > > +++ b/drivers/clocksource/Kconfig > > @@ -407,6 +407,15 @@ config

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-24 Thread Daniel Lezcano
On 08/04/2016 06:30 AM, Rich Felker wrote: > At the hardware level, the J-Core PIT is integrated with the interrupt > controller, but it is represented as its own device and has an > independent programming interface. It provides a 12-bit countdown > timer, which is not presently used, and a

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-24 Thread Daniel Lezcano
On 08/04/2016 06:30 AM, Rich Felker wrote: > At the hardware level, the J-Core PIT is integrated with the interrupt > controller, but it is represented as its own device and has an > independent programming interface. It provides a 12-bit countdown > timer, which is not presently used, and a

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-04 Thread Rich Felker
On Thu, Aug 04, 2016 at 02:24:51PM +0600, Alexnader Kuleshov wrote: > Hello Rich, > > On 08-04-16, Rich Felker wrote: > > At the hardware level, the J-Core PIT is integrated with the interrupt > > controller, but it is represented as its own device and has an > > independent programming

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-04 Thread Rich Felker
On Thu, Aug 04, 2016 at 02:24:51PM +0600, Alexnader Kuleshov wrote: > Hello Rich, > > On 08-04-16, Rich Felker wrote: > > At the hardware level, the J-Core PIT is integrated with the interrupt > > controller, but it is represented as its own device and has an > > independent programming

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-04 Thread Alexnader Kuleshov
Hello Rich, On 08-04-16, Rich Felker wrote: > At the hardware level, the J-Core PIT is integrated with the interrupt > controller, but it is represented as its own device and has an > independent programming interface. It provides a 12-bit countdown > timer, which is not presently used, and a

Re: [PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-04 Thread Alexnader Kuleshov
Hello Rich, On 08-04-16, Rich Felker wrote: > At the hardware level, the J-Core PIT is integrated with the interrupt > controller, but it is represented as its own device and has an > independent programming interface. It provides a 12-bit countdown > timer, which is not presently used, and a

[PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-03 Thread Rich Felker
At the hardware level, the J-Core PIT is integrated with the interrupt controller, but it is represented as its own device and has an independent programming interface. It provides a 12-bit countdown timer, which is not presently used, and a periodic timer. The interval length for the latter is

[PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-03 Thread Rich Felker
At the hardware level, the J-Core PIT is integrated with the interrupt controller, but it is represented as its own device and has an independent programming interface. It provides a 12-bit countdown timer, which is not presently used, and a periodic timer. The interval length for the latter is

[PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-02 Thread Rich Felker
At the hardware level, the J-Core PIT is integrated with the interrupt controller, but it is represented as its own device and has an independent programming interface. It provides a 12-bit countdown timer, which is not presently used, and a periodic timer. The interval length for the latter is

[PATCH v6 2/2] clocksource: add J-Core timer/clocksource driver

2016-08-02 Thread Rich Felker
At the hardware level, the J-Core PIT is integrated with the interrupt controller, but it is represented as its own device and has an independent programming interface. It provides a 12-bit countdown timer, which is not presently used, and a periodic timer. The interval length for the latter is