Re: [PATCH v6 2/2] drm/bridge: hx8837: add a Himax HX8837 display controller driver

2020-10-31 Thread Sam Ravnborg
Hi Lubomir. > > > > > + select BACKLIGHT_CLASS_DEVICE > > Please use a depends - using select on a symbol with a prompt is always > > wrong. Yeah, I know you then need to enable backlight to see this > > driver. Sorry, but this is the best we can do now. > > Many other drivers can cope with

Re: [PATCH v6 2/2] drm/bridge: hx8837: add a Himax HX8837 display controller driver

2020-10-31 Thread Lubomir Rintel
Hello Sam, thanks for your response. On Sat, Oct 31, 2020 at 09:01:37AM +0100, Sam Ravnborg wrote: > Hi Lubomir. > > On Fri, Oct 30, 2020 at 04:08:00AM +0100, Lubomir Rintel wrote: > > Himax HX8837 is used to drive the LCD panel on OLPC platforms. > > > > It controls the panel backlight and is

Re: [PATCH v6 2/2] drm/bridge: hx8837: add a Himax HX8837 display controller driver

2020-10-31 Thread Sam Ravnborg
Hi Lubomir. On Fri, Oct 30, 2020 at 04:08:00AM +0100, Lubomir Rintel wrote: > Himax HX8837 is used to drive the LCD panel on OLPC platforms. > > It controls the panel backlight and is able to refresh it when the LCD > controller (and the rest of the plaform) is powered off. > > It also converts

[PATCH v6 2/2] drm/bridge: hx8837: add a Himax HX8837 display controller driver

2020-10-29 Thread Lubomir Rintel
Himax HX8837 is used to drive the LCD panel on OLPC platforms. It controls the panel backlight and is able to refresh it when the LCD controller (and the rest of the plaform) is powered off. It also converts regular RGB color data from the LCDC so that it looks reasonable on the OLPC LCD panel