Re: [PATCH v6 2/2] mmc: host: meson-mx-sdhc: new driver for the Amlogic Meson SDHC host

2020-05-12 Thread Jerome Brunet
On Sun 10 May 2020 at 22:52, Martin Blumenstingl wrote: > Hi Jerome, > > On Tue, May 5, 2020 at 6:05 PM Jerome Brunet wrote: > [...] >> > 2. Keep the existing approach, with devm_clk_get(). I am fine with >> > this as well, we can always switch to 1) later on. >> >> I have a problem with this

Re: [PATCH v6 2/2] mmc: host: meson-mx-sdhc: new driver for the Amlogic Meson SDHC host

2020-05-10 Thread Martin Blumenstingl
Hi Jerome, On Tue, May 5, 2020 at 6:05 PM Jerome Brunet wrote: [...] > > 2. Keep the existing approach, with devm_clk_get(). I am fine with > > this as well, we can always switch to 1) later on. > > I have a problem with this approach. > The dt-bindings would include "#clock-cells = <1>" for a de

Re: [PATCH v6 2/2] mmc: host: meson-mx-sdhc: new driver for the Amlogic Meson SDHC host

2020-05-05 Thread Ulf Hansson
On Tue, 5 May 2020 at 18:05, Jerome Brunet wrote: > > > On Tue 05 May 2020 at 10:17, Ulf Hansson wrote: > > > [...] > > > >> >> > + > >> >> > + return devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get, > >> >> > +onecell_data); > >> >> > >> >> I th

Re: [PATCH v6 2/2] mmc: host: meson-mx-sdhc: new driver for the Amlogic Meson SDHC host

2020-05-05 Thread Jerome Brunet
On Tue 05 May 2020 at 10:17, Ulf Hansson wrote: > [...] > >> >> > + >> >> > + return devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get, >> >> > +onecell_data); >> >> >> >> I think registering a provider for a module that does not provide clocks >

Re: [PATCH v6 2/2] mmc: host: meson-mx-sdhc: new driver for the Amlogic Meson SDHC host

2020-05-05 Thread Ulf Hansson
[...] > >> > + > >> > + return devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get, > >> > +onecell_data); > >> > >> I think registering a provider for a module that does not provide clocks > >> to any other device is a bit overkill. > >> > >> I under

Re: [PATCH v6 2/2] mmc: host: meson-mx-sdhc: new driver for the Amlogic Meson SDHC host

2020-04-30 Thread Jerome Brunet
On Thu 30 Apr 2020 at 13:10, Ulf Hansson wrote: > + Stephen > > On Thu, 30 Apr 2020 at 11:47, Jerome Brunet wrote: >> >> >> On Tue 28 Apr 2020 at 23:02, Martin Blumenstingl >> wrote: >> >> > The SDHC MMC host controller on Amlogic SoCs provides an eMMC and MMC >> > card interface with 1/4/8-

Re: [PATCH v6 2/2] mmc: host: meson-mx-sdhc: new driver for the Amlogic Meson SDHC host

2020-04-30 Thread Ulf Hansson
+ Stephen On Thu, 30 Apr 2020 at 11:47, Jerome Brunet wrote: > > > On Tue 28 Apr 2020 at 23:02, Martin Blumenstingl > wrote: > > > The SDHC MMC host controller on Amlogic SoCs provides an eMMC and MMC > > card interface with 1/4/8-bit bus width. > > It supports eMMC spec 4.4x/4.5x including HS2

Re: [PATCH v6 2/2] mmc: host: meson-mx-sdhc: new driver for the Amlogic Meson SDHC host

2020-04-30 Thread Jerome Brunet
On Tue 28 Apr 2020 at 23:02, Martin Blumenstingl wrote: > The SDHC MMC host controller on Amlogic SoCs provides an eMMC and MMC > card interface with 1/4/8-bit bus width. > It supports eMMC spec 4.4x/4.5x including HS200 (up to 100MHz clock). > > The public S805 datasheet [0] contains a short

[PATCH v6 2/2] mmc: host: meson-mx-sdhc: new driver for the Amlogic Meson SDHC host

2020-04-28 Thread Martin Blumenstingl
The SDHC MMC host controller on Amlogic SoCs provides an eMMC and MMC card interface with 1/4/8-bit bus width. It supports eMMC spec 4.4x/4.5x including HS200 (up to 100MHz clock). The public S805 datasheet [0] contains a short documentation about the registers. Unfortunately it does not describe