Re: [PATCH v6 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-02-14 Thread Yash Shah
On Thu, Feb 14, 2019 at 2:04 PM Uwe Kleine-König wrote: > > Hello, > > On Thu, Feb 14, 2019 at 01:25:27PM +0530, Yash Shah wrote: > > On Wed, Feb 13, 2019 at 4:05 PM Uwe Kleine-König > > wrote: > > > On Wed, Feb 13, 2019 at 02:56:18PM +0530, Yash Shah wrote: > > > > +static int pwm_sifive_enable(

Re: [PATCH v6 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-02-14 Thread Uwe Kleine-König
Hello, On Thu, Feb 14, 2019 at 01:25:27PM +0530, Yash Shah wrote: > On Wed, Feb 13, 2019 at 4:05 PM Uwe Kleine-König > wrote: > > On Wed, Feb 13, 2019 at 02:56:18PM +0530, Yash Shah wrote: > > > +static int pwm_sifive_enable(struct pwm_chip *chip, struct pwm_device > > > *dev, > > > +

Re: [PATCH v6 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-02-13 Thread Yash Shah
On Wed, Feb 13, 2019 at 4:05 PM Uwe Kleine-König wrote: > > Hello, > > On Wed, Feb 13, 2019 at 02:56:18PM +0530, Yash Shah wrote: > > Adds a PWM driver for PWM chip present in SiFive's HiFive Unleashed SoC. > > > > Signed-off-by: Wesley W. Terpstra > > [Atish: Various fixes and code cleanup] > >

Re: [PATCH v6 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-02-13 Thread Thierry Reding
On Wed, Feb 13, 2019 at 11:34:59AM +0100, Uwe Kleine-König wrote: > On Wed, Feb 13, 2019 at 02:56:18PM +0530, Yash Shah wrote: [...] > > + unsigned long scale_pow = > > + div64_ul(pwm->real_period * (u64)rate, NSEC_PER_SEC); > > + int scale = clamp(ilog2(scale_pow) - PWM_SIFIV

Re: [PATCH v6 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-02-13 Thread Uwe Kleine-König
Hello, On Wed, Feb 13, 2019 at 02:56:18PM +0530, Yash Shah wrote: > Adds a PWM driver for PWM chip present in SiFive's HiFive Unleashed SoC. > > Signed-off-by: Wesley W. Terpstra > [Atish: Various fixes and code cleanup] > Signed-off-by: Atish Patra > Signed-off-by: Yash Shah > --- > drivers/

[PATCH v6 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-02-13 Thread Yash Shah
Adds a PWM driver for PWM chip present in SiFive's HiFive Unleashed SoC. Signed-off-by: Wesley W. Terpstra [Atish: Various fixes and code cleanup] Signed-off-by: Atish Patra Signed-off-by: Yash Shah --- drivers/pwm/Kconfig | 11 ++ drivers/pwm/Makefile | 1 + drivers/pwm/pwm-sifive